[Catalyst-commits] r10582 - in trunk/Catalyst-Model-DBIC-Schema: . lib/Catalyst/Helper/Model/DBIC

[dandv at dev.catalyst.perl.org]

Author: dandv
Date: 2009-06-18 07:17:09 +0000 (Thu, 18 Jun 2009)
New Revision: 10582

Modified:
   trunk/Catalyst-Model-DBIC-Schema/Changes
   trunk/Catalyst-Model-DBIC-Schema/TODO
   trunk/Catalyst-Model-DBIC-Schema/lib/Catalyst/Helper/Model/DBIC/Schema.pm
Log:
Fixed infinte loop if SQLite connect_info has only a DSN (RT #47101)

Modified: trunk/Catalyst-Model-DBIC-Schema/Changes
===================================================================
--- trunk/Catalyst-Model-DBIC-Schema/Changes	2009-06-18 04:13:07 UTC (rev 10581)
+++ trunk/Catalyst-Model-DBIC-Schema/Changes	2009-06-18 07:17:09 UTC (rev 10582)
@@ -1,5 +1,7 @@
 Revision history for Perl extension Catalyst::Model::DBIC::Schema
 
+        - Fixed infinte loop if SQLite connect_info has only a DSN (dandv, RT #47101)
+
 0.24  Tue Jun 16 06:18:58 PDT 2009
         - Add tests for issues with Class::C3 which are caused to
           applications which use new Catalyst but old DBIC, and have
@@ -9,11 +11,11 @@
         - helper passes loader opts to dynamic schemas
         - conversion to Moose
         - cursor caching support (via
-	  Catalyst::TraitFor::Model::DBIC::Schema::Caching)
-	- ::Storage::Replicated support (via ::Replicated trait)
+          Catalyst::TraitFor::Model::DBIC::Schema::Caching)
+        - ::Storage::Replicated support (via ::Replicated trait)
         - switch to hashref connect_info for DBIC 8100
         - better helper option parsing, with support for more options
-	- more tests
+        - more tests
 
 0.23  Sun Mar  8 20:30:02 GMT 2009
         - Kill a couple of warnings (one due to MRO::Compat)

Modified: trunk/Catalyst-Model-DBIC-Schema/TODO
===================================================================
--- trunk/Catalyst-Model-DBIC-Schema/TODO	2009-06-18 04:13:07 UTC (rev 10581)
+++ trunk/Catalyst-Model-DBIC-Schema/TODO	2009-06-18 07:17:09 UTC (rev 10582)
@@ -1 +1,3 @@
 timezone and locale support for dates at helper time
+
+see why warnings get silenced (https://rt.cpan.org/Ticket/Display.html?id=47101)

Modified: trunk/Catalyst-Model-DBIC-Schema/lib/Catalyst/Helper/Model/DBIC/Schema.pm
===================================================================
--- trunk/Catalyst-Model-DBIC-Schema/lib/Catalyst/Helper/Model/DBIC/Schema.pm	2009-06-18 04:13:07 UTC (rev 10581)
+++ trunk/Catalyst-Model-DBIC-Schema/lib/Catalyst/Helper/Model/DBIC/Schema.pm	2009-06-18 07:17:09 UTC (rev 10582)
@@ -400,7 +400,7 @@
 
     if ($dsn =~ /sqlite/i) {
         ($user, $password) = ('', '');
-        shift @$connect_info while $connect_info->[0] eq '';
+        shift @$connect_info while @$connect_info and $connect_info->[0] eq '';
     } else {
         ($user, $password) = splice @$connect_info, 0, 2;
     }