[Catalyst-commits] r10617 - in Catalyst-Plugin-Session/0.00/trunk: . lib/Catalyst/Plugin t

t0m at dev.catalyst.perl.org t0m at dev.catalyst.perl.org
Tue Jun 23 08:16:36 GMT 2009


Author: t0m
Date: 2009-06-23 08:16:31 +0000 (Tue, 23 Jun 2009)
New Revision: 10617

Modified:
   Catalyst-Plugin-Session/0.00/trunk/Changes
   Catalyst-Plugin-Session/0.00/trunk/lib/Catalyst/Plugin/Session.pm
   Catalyst-Plugin-Session/0.00/trunk/t/05_semi_persistent_flash.t
   Catalyst-Plugin-Session/0.00/trunk/t/live_app.t
   Catalyst-Plugin-Session/0.00/trunk/t/live_session_fixation.t
   Catalyst-Plugin-Session/0.00/trunk/t/live_verify_user_agent.t
Log:
Checking in changes prior to tagging of version 0.24.  Changelog diff is:

Index: Changes
===================================================================
--- Changes	(revision 10553)
+++ Changes	(working copy)
@@ -1,5 +1,11 @@
 Revision history for Perl extension Catalyst::Plugin::Session
 
+0.24 2009-06-23
+        - Be more paranoid about getting values of $c->req to avoid issues
+          with old Test::WWW::Mechanize::Catalyst.
+        - Check we have a modern version of TWMC before doing the tests which
+          need it.
+
 0.23 2009-06-16
         - Add the verify_user_agent config parameter (kmx)
         - Add a test case to prove that logging in with a session cookie still 


Modified: Catalyst-Plugin-Session/0.00/trunk/Changes
===================================================================
--- Catalyst-Plugin-Session/0.00/trunk/Changes	2009-06-22 19:48:56 UTC (rev 10616)
+++ Catalyst-Plugin-Session/0.00/trunk/Changes	2009-06-23 08:16:31 UTC (rev 10617)
@@ -1,5 +1,11 @@
 Revision history for Perl extension Catalyst::Plugin::Session
 
+0.24 2009-06-23
+        - Be more paranoid about getting values of $c->req to avoid issues
+          with old Test::WWW::Mechanize::Catalyst.
+        - Check we have a modern version of TWMC before doing the tests which
+          need it.
+
 0.23 2009-06-16
         - Add the verify_user_agent config parameter (kmx)
         - Add a test case to prove that logging in with a session cookie still 

Modified: Catalyst-Plugin-Session/0.00/trunk/lib/Catalyst/Plugin/Session.pm
===================================================================
--- Catalyst-Plugin-Session/0.00/trunk/lib/Catalyst/Plugin/Session.pm	2009-06-22 19:48:56 UTC (rev 10616)
+++ Catalyst-Plugin-Session/0.00/trunk/lib/Catalyst/Plugin/Session.pm	2009-06-23 08:16:31 UTC (rev 10617)
@@ -13,7 +13,7 @@
 
 use namespace::clean -except => 'meta';
 
-our $VERSION = '0.23';
+our $VERSION = '0.24';
 
 my @session_data_accessors; # used in delete_session
 
@@ -463,12 +463,12 @@
 
             (
                 $c->config->{session}{verify_address}
-                ? ( __address => $c->request->address )
+                ? ( __address => $c->request->address||'' )
                 : ()
             ),
             (
                 $c->config->{session}{verify_user_agent}
-                ? ( __user_agent => $c->request->user_agent )
+                ? ( __user_agent => $c->request->user_agent||'' )
                 : ()
             ),
         }

Modified: Catalyst-Plugin-Session/0.00/trunk/t/05_semi_persistent_flash.t
===================================================================
--- Catalyst-Plugin-Session/0.00/trunk/t/05_semi_persistent_flash.t	2009-06-22 19:48:56 UTC (rev 10616)
+++ Catalyst-Plugin-Session/0.00/trunk/t/05_semi_persistent_flash.t	2009-06-23 08:16:31 UTC (rev 10617)
@@ -8,9 +8,12 @@
         or plan skip_all =>
             "Catalyst::Plugin::Session::State::Cookie version 0.03 or higher is required for this test";
 
-    eval { require Test::WWW::Mechanize::Catalyst }
-      or plan skip_all =>
-      'Test::WWW::Mechanize::Catalyst is required for this test';
+    eval {
+        require Test::WWW::Mechanize::Catalyst;
+        Test::WWW::Mechanize::Catalyst->VERSION(0.51);
+    }
+    or plan skip_all =>
+        'Test::WWW::Mechanize::Catalyst >= 0.51 is required for this test';
 
     plan tests => '10';
 

Modified: Catalyst-Plugin-Session/0.00/trunk/t/live_app.t
===================================================================
--- Catalyst-Plugin-Session/0.00/trunk/t/live_app.t	2009-06-22 19:48:56 UTC (rev 10616)
+++ Catalyst-Plugin-Session/0.00/trunk/t/live_app.t	2009-06-23 08:16:31 UTC (rev 10617)
@@ -10,9 +10,12 @@
       or plan skip_all =>
       "Catalyst::Plugin::Session::State::Cookie 0.03 or higher is required for this test";
 
-    eval { require Test::WWW::Mechanize::Catalyst }
-      or plan skip_all =>
-      "Test::WWW::Mechanize::Catalyst is required for this test";
+    eval {
+        require Test::WWW::Mechanize::Catalyst;
+        Test::WWW::Mechanize::Catalyst->VERSION(0.51);
+    }
+    or plan skip_all =>
+        'Test::WWW::Mechanize::Catalyst >= 0.51 is required for this test';
 
     plan tests => 36;
 }

Modified: Catalyst-Plugin-Session/0.00/trunk/t/live_session_fixation.t
===================================================================
--- Catalyst-Plugin-Session/0.00/trunk/t/live_session_fixation.t	2009-06-22 19:48:56 UTC (rev 10616)
+++ Catalyst-Plugin-Session/0.00/trunk/t/live_session_fixation.t	2009-06-23 08:16:31 UTC (rev 10617)
@@ -10,9 +10,12 @@
       or plan skip_all =>
       "Catalyst::Plugin::Session::State::Cookie 0.03 or higher is required for this test";
 
-    eval { require Test::WWW::Mechanize::Catalyst }
-      or plan skip_all =>
-      "Test::WWW::Mechanize::Catalyst is required for this test";
+    eval {
+        require Test::WWW::Mechanize::Catalyst;
+        Test::WWW::Mechanize::Catalyst->VERSION(0.51);
+    }
+    or plan skip_all =>
+        'Test::WWW::Mechanize::Catalyst >= 0.51 is required for this test';
 
     plan tests => 2;
 }

Modified: Catalyst-Plugin-Session/0.00/trunk/t/live_verify_user_agent.t
===================================================================
--- Catalyst-Plugin-Session/0.00/trunk/t/live_verify_user_agent.t	2009-06-22 19:48:56 UTC (rev 10616)
+++ Catalyst-Plugin-Session/0.00/trunk/t/live_verify_user_agent.t	2009-06-23 08:16:31 UTC (rev 10617)
@@ -10,9 +10,12 @@
       or plan skip_all =>
       "Catalyst::Plugin::Session::State::Cookie 0.03 or higher is required for this test";
 
-    eval { require Test::WWW::Mechanize::Catalyst }
-      or plan skip_all =>
-      "Test::WWW::Mechanize::Catalyst is required for this test";
+    eval {
+        require Test::WWW::Mechanize::Catalyst;
+        Test::WWW::Mechanize::Catalyst->VERSION(0.51);
+    }
+    or plan skip_all =>
+        'Test::WWW::Mechanize::Catalyst >= 0.51 is required for this test';
 
     plan tests => 12;
 }




More information about the Catalyst-commits mailing list