[Catalyst-commits] r9977 - Catalyst-Runtime/5.80/trunk/lib/Catalyst

[rafl at dev.catalyst.perl.org]

Author: rafl
Date: 2009-05-01 05:55:04 +0100 (Fri, 01 May 2009)
New Revision: 9977

Modified:
   Catalyst-Runtime/5.80/trunk/lib/Catalyst/Request.pm
Log:
Clarify limitations of $request->base and $request->secure.

Courtesy of Phil Mitchell <phil at 2people.org>.

Modified: Catalyst-Runtime/5.80/trunk/lib/Catalyst/Request.pm
===================================================================
--- Catalyst-Runtime/5.80/trunk/lib/Catalyst/Request.pm	2009-05-01 02:34:40 UTC (rev 9976)
+++ Catalyst-Runtime/5.80/trunk/lib/Catalyst/Request.pm	2009-05-01 04:55:04 UTC (rev 9977)
@@ -223,7 +223,10 @@
 
 =head2 $req->base
 
-Contains the URI base. This will always have a trailing slash.
+Contains the URI base. This will always have a trailing slash. Note that the
+URI scheme (eg., http vs. https) must be determined through heuristics;
+depending on your server configuration, it may be incorrect. See $req->secure
+for more info.
 
 If your application was queried with the URI
 C<http://localhost:3000/some/path> then C<base> is C<http://localhost:3000/>.
@@ -459,7 +462,12 @@
 
 =head2 $req->secure
 
-Returns true or false, indicating whether the connection is secure (https).
+Returns true or false, indicating whether the connection is secure
+(https). Note that the URI scheme (eg., http vs. https) must be determined
+through heuristics, and therefore the reliablity of $req->secure will depend
+on your server configuration. If you are serving secure pages on the standard
+SSL port (443) and/or setting the HTTPS environment variable, $req->secure
+should be valid.
 
 =head2 $req->captures