[Catalyst-commits] r9990 - in trunk/Catalyst-Controller-WrapCGI: . lib/Catalyst/Controller

[caelum at dev.catalyst.perl.org]

Author: caelum
Date: 2009-05-03 04:34:45 +0000 (Sun, 03 May 2009)
New Revision: 9990

Modified:
   trunk/Catalyst-Controller-WrapCGI/Changes
   trunk/Catalyst-Controller-WrapCGI/Makefile.PL
   trunk/Catalyst-Controller-WrapCGI/lib/Catalyst/Controller/WrapCGI.pm
Log:
C::C::WrapCGI - add note about nph scripts not working (caelum)

Modified: trunk/Catalyst-Controller-WrapCGI/Changes
===================================================================
--- trunk/Catalyst-Controller-WrapCGI/Changes	2009-05-03 02:40:36 UTC (rev 9989)
+++ trunk/Catalyst-Controller-WrapCGI/Changes	2009-05-03 04:34:45 UTC (rev 9990)
@@ -1,5 +1,8 @@
 Revision history for Catalyst-Controller-WrapCGI
 
+0.0035  2009-05-03 04:33:27
+    - add a note about nph cgis not working (caelum)
+
 0.0034  2009-04-30 16:38:00
     - remove all CGI specific env vars by default (caelum)
 

Modified: trunk/Catalyst-Controller-WrapCGI/Makefile.PL
===================================================================
--- trunk/Catalyst-Controller-WrapCGI/Makefile.PL	2009-05-03 02:40:36 UTC (rev 9989)
+++ trunk/Catalyst-Controller-WrapCGI/Makefile.PL	2009-05-03 04:34:45 UTC (rev 9990)
@@ -3,23 +3,13 @@
 name     'Catalyst-Controller-WrapCGI';
 all_from 'lib/Catalyst/Controller/WrapCGI.pm';
 author   'Matt S. Trout <mst at shadowcat.co.uk>';
-include  'Module::AutoInstall';
 
 requires 'Catalyst' => '5.80002';
-requires 'parent';
-requires 'Task::Weaken';
 requires 'HTTP::Request::AsCGI' => '0.8';;
-requires 'URI';
 requires 'File::Find::Rule';
 requires 'List::MoreUtils';
 requires 'File::Slurp';
-requires 'namespace::clean';
 
-if($] < 5.009_005) {
-    requires 'Class::C3::XS' => '0.08';
-    requires 'Class::C3' => '0.20';
-}
-
 test_requires 'Catalyst::Plugin::Static::Simple';
 
 build_requires 'Test::More' => '0.86';

Modified: trunk/Catalyst-Controller-WrapCGI/lib/Catalyst/Controller/WrapCGI.pm
===================================================================
--- trunk/Catalyst-Controller-WrapCGI/lib/Catalyst/Controller/WrapCGI.pm	2009-05-03 02:40:36 UTC (rev 9989)
+++ trunk/Catalyst-Controller-WrapCGI/lib/Catalyst/Controller/WrapCGI.pm	2009-05-03 04:34:45 UTC (rev 9990)
@@ -20,11 +20,11 @@
 
 =head1 VERSION
 
-Version 0.0034
+Version 0.0035
 
 =cut
 
-our $VERSION = '0.0034';
+our $VERSION = '0.0035';
 
 =head1 SYNOPSIS
 
@@ -52,7 +52,7 @@
             pass_env PERL5LIB
             pass_env PATH
             pass_env /^MYAPP_/
-            kill_env MOD_PERL
+            kill_env MYAPP_BAD
         </CGI>
     </Controller::Foo>
 
@@ -210,7 +210,8 @@
               ($username ? (REMOTE_USER => $username) : ()),
               %$filtered_env,
               PATH_INFO => $path_info,
-              FILEPATH_INFO => '/'.$c->action.$path_info, # eww
+# eww, this is likely broken:
+              FILEPATH_INFO => '/'.$c->action.$path_info,
               SCRIPT_NAME => $c->uri_for($c->action)->path
             );
 
@@ -313,6 +314,25 @@
 
 __PACKAGE__->meta->make_immutable;
 
+=head1 DIRECT SOCKET/NPH SCRIPTS
+
+This currently won't work:
+
+    #!/usr/bin/perl
+
+    use CGI ':standard';
+
+    $| = 1;
+
+    print header;
+
+    for (0..1000) {
+        print $_, br, "\n";
+    }
+
+because the coderef is executed synchronously with C<STDOUT> pointing to a temp
+file.
+
 =head1 ACKNOWLEDGEMENTS
 
 Original development sponsored by L<http://www.altinity.com/>