[Catalyst-commits] r10125 - Catalyst-Runtime/5.80/trunk/lib/Catalyst

[t0m at dev.catalyst.perl.org]

Author: t0m
Date: 2009-05-13 19:55:11 +0000 (Wed, 13 May 2009)
New Revision: 10125

Modified:
   Catalyst-Runtime/5.80/trunk/lib/Catalyst/Controller.pm
Log:
Highlight back compat after discussion/confusion earlier. Also clean up BUILD => BUILDARGS as suggested by mst.

Modified: Catalyst-Runtime/5.80/trunk/lib/Catalyst/Controller.pm
===================================================================
--- Catalyst-Runtime/5.80/trunk/lib/Catalyst/Controller.pm	2009-05-13 19:53:35 UTC (rev 10124)
+++ Catalyst-Runtime/5.80/trunk/lib/Catalyst/Controller.pm	2009-05-13 19:55:11 UTC (rev 10125)
@@ -17,7 +17,7 @@
     (
      is => 'rw',
      isa => 'Str',
-     init_arg => 'path',
+     init_arg => 'path', # 5.7 compat
      predicate => 'has_path_prefix',
     );
 
@@ -25,7 +25,7 @@
     (
      is => 'rw',
      isa => 'Str',
-     init_arg => 'namespace',
+     init_arg => 'namespace', # 5.7 compat
      predicate => 'has_action_namespace',
     );
 
@@ -33,16 +33,18 @@
     (
      is => 'rw',
      isa => 'HashRef',
-     init_arg => undef,
+     init_arg => 'action', # 5.7 compat
     );
 
-sub BUILD {
-    my ($self, $args) = @_;
+around BUILDARGS => sub { # Icky 5.7 compat
+    my $orig = shift;
+    my $self = shift;
+    my $args = $self->$orig(@_);
     my $action  = delete $args->{action}  || {};
     my $actions = delete $args->{actions} || {};
-    my $attr_value = $self->merge_config_hashes($actions, $action);
-    $self->_controller_actions($attr_value);
-}
+    $args->{action} = $self->merge_config_hashes($actions, $action);
+    return $args;
+};
 
 =head1 NAME