[Catalyst-commits] r12018 - in Catalyst-Runtime/5.80/branches/better_scripts: . lib/Catalyst

[t0m at dev.catalyst.perl.org]

Author: t0m
Date: 2009-11-26 00:35:31 +0000 (Thu, 26 Nov 2009)
New Revision: 12018

Modified:
   Catalyst-Runtime/5.80/branches/better_scripts/TODO.scripts
   Catalyst-Runtime/5.80/branches/better_scripts/lib/Catalyst/ScriptRole.pm
Log:
Remove most of the horrible

Modified: Catalyst-Runtime/5.80/branches/better_scripts/TODO.scripts
===================================================================
--- Catalyst-Runtime/5.80/branches/better_scripts/TODO.scripts	2009-11-26 00:25:01 UTC (rev 12017)
+++ Catalyst-Runtime/5.80/branches/better_scripts/TODO.scripts	2009-11-26 00:35:31 UTC (rev 12018)
@@ -1,2 +1 @@
-* Fix the horrible hacking that is Catalyst::ScriptRole::Useage
 * Fix TODO tests

Modified: Catalyst-Runtime/5.80/branches/better_scripts/lib/Catalyst/ScriptRole.pm
===================================================================
--- Catalyst-Runtime/5.80/branches/better_scripts/lib/Catalyst/ScriptRole.pm	2009-11-26 00:25:01 UTC (rev 12017)
+++ Catalyst-Runtime/5.80/branches/better_scripts/lib/Catalyst/ScriptRole.pm	2009-11-26 00:35:31 UTC (rev 12018)
@@ -9,6 +9,7 @@
     excludes => [qw/
         _getopt_spec_warnings
         _getopt_spec_exception
+        _getopt_full_usage
     /],
 };
 
@@ -33,7 +34,7 @@
     warn @_;
 }
 
-sub _exit_with_usage {
+sub _getopt_full_usage {
     my $self = shift;
     pod2usage();
     exit 0;
@@ -41,7 +42,7 @@
 
 before run => sub {
     my $self = shift;
-    $self->_exit_with_usage if $self->help;
+    $self->_getopt_full_usage if $self->help;
 };
 
 sub run {
@@ -60,25 +61,6 @@
     $app->run($self->_application_args);
 }
 
-# GROSS HACK, temporary until MX::Getopt gets some proper refactoring and unfucking..
-around '_parse_argv' => sub {
-    my ($orig, $self, @args) = @_;
-    my %data = eval { $self->$orig(@args) };
-    $self->_exit_with_usage($@) if $@;
-    $data{usage} = Catalyst::ScriptRole::Useage->new(code => sub { shift; $self->_exit_with_usage(@_) });
-    return %data;
-};
-
-# This package is going away.
-package # Hide from PAUSE
-    Catalyst::ScriptRole::Useage;
-use Moose;
-use namespace::autoclean;
-
-has code => ( is => 'ro', required => 1 );
-
-sub die { shift->code->(@_) }
-
 1;
 
 =head1 NAME