[Catalyst-commits] r11346 - in Catalyst-Runtime/5.80/branches/deprecate_appclass_actions: . lib lib/Catalyst t/aggregate

t0m at dev.catalyst.perl.org t0m at dev.catalyst.perl.org
Thu Sep 10 01:11:49 GMT 2009


Author: t0m
Date: 2009-09-10 01:11:49 +0000 (Thu, 10 Sep 2009)
New Revision: 11346

Modified:
   Catalyst-Runtime/5.80/branches/deprecate_appclass_actions/
   Catalyst-Runtime/5.80/branches/deprecate_appclass_actions/Changes
   Catalyst-Runtime/5.80/branches/deprecate_appclass_actions/lib/Catalyst.pm
   Catalyst-Runtime/5.80/branches/deprecate_appclass_actions/lib/Catalyst/Runtime.pm
   Catalyst-Runtime/5.80/branches/deprecate_appclass_actions/t/aggregate/live_engine_request_escaped_path.t
Log:
 r11369 at t0mlaptop (orig r11339):  marcus | 2009-09-09 18:05:32 +0100
 un-TODO passing TODO tests
 r11370 at t0mlaptop (orig r11340):  marcus | 2009-09-09 18:08:03 +0100
 Prepare for release
 r11374 at t0mlaptop (orig r11344):  groditi | 2009-09-09 22:06:59 +0100
 add myself to contributors
 r11375 at t0mlaptop (orig r11345):  t0m | 2009-09-10 01:13:56 +0100
 Fix warnings in upcoming moose



Property changes on: Catalyst-Runtime/5.80/branches/deprecate_appclass_actions
___________________________________________________________________
Name: svk:merge
   - 1c72fc7c-9ce4-42af-bf25-3bfe470ff1e8:/local/Catalyst/trunk/Catalyst-Runtime:9763
4ad37cd2-5fec-0310-835f-b3785c72a374:/Catalyst-Runtime/5.70/branches/compres:7999
4ad37cd2-5fec-0310-835f-b3785c72a374:/Catalyst-Runtime/5.70/branches/context_go:8001
4ad37cd2-5fec-0310-835f-b3785c72a374:/Catalyst-Runtime/5.70/trunk:8533
4ad37cd2-5fec-0310-835f-b3785c72a374:/Catalyst-Runtime/5.80/branches/Catalyst-Test-Updates:8363
4ad37cd2-5fec-0310-835f-b3785c72a374:/Catalyst-Runtime/5.80/branches/add_captures_to_visit:9546
4ad37cd2-5fec-0310-835f-b3785c72a374:/Catalyst-Runtime/5.80/branches/index_default_fuckage:10646
4ad37cd2-5fec-0310-835f-b3785c72a374:/Catalyst-Runtime/5.80/branches/moose:7911
4ad37cd2-5fec-0310-835f-b3785c72a374:/Catalyst-Runtime/5.80/branches/namespace_handling_refactor:10655
4ad37cd2-5fec-0310-835f-b3785c72a374:/Catalyst-Runtime/5.80/trunk:11336
4ad37cd2-5fec-0310-835f-b3785c72a374:/branches/Catalyst-ChildOf:4443
4ad37cd2-5fec-0310-835f-b3785c72a374:/branches/Catalyst-Runtime-jrockway:5857
4ad37cd2-5fec-0310-835f-b3785c72a374:/branches/Catalyst-component-setup:4320
4ad37cd2-5fec-0310-835f-b3785c72a374:/branches/Catalyst-docs:4325
4ad37cd2-5fec-0310-835f-b3785c72a374:/branches/current/Catalyst-Runtime:5142
4ad37cd2-5fec-0310-835f-b3785c72a374:/trunk/Catalyst:4483
4ad37cd2-5fec-0310-835f-b3785c72a374:/trunk/Catalyst-Runtime:6165
8a9521aa-ff93-41d6-9f87-b05cafcdab40:/local/cat/Catalyst-Runtime/5.80/trunk:8157
d7608cd0-831c-0410-93c0-e5b306c3c028:/local/Catalyst/Catalyst-Runtime:8339
d7608cd0-831c-0410-93c0-e5b306c3c028:/local/Catalyst/Catalyst-Runtime-jrockway:8342
e56d974f-7718-0410-8b1c-b347a71765b2:/local/Catalyst-Runtime:6511
e56d974f-7718-0410-8b1c-b347a71765b2:/local/Catalyst-Runtime-current:10442
   + 1c72fc7c-9ce4-42af-bf25-3bfe470ff1e8:/local/Catalyst/trunk/Catalyst-Runtime:9763
4ad37cd2-5fec-0310-835f-b3785c72a374:/Catalyst-Runtime/5.70/branches/compres:7999
4ad37cd2-5fec-0310-835f-b3785c72a374:/Catalyst-Runtime/5.70/branches/context_go:8001
4ad37cd2-5fec-0310-835f-b3785c72a374:/Catalyst-Runtime/5.70/trunk:8533
4ad37cd2-5fec-0310-835f-b3785c72a374:/Catalyst-Runtime/5.80/branches/Catalyst-Test-Updates:8363
4ad37cd2-5fec-0310-835f-b3785c72a374:/Catalyst-Runtime/5.80/branches/add_captures_to_visit:9546
4ad37cd2-5fec-0310-835f-b3785c72a374:/Catalyst-Runtime/5.80/branches/index_default_fuckage:10646
4ad37cd2-5fec-0310-835f-b3785c72a374:/Catalyst-Runtime/5.80/branches/moose:7911
4ad37cd2-5fec-0310-835f-b3785c72a374:/Catalyst-Runtime/5.80/branches/namespace_handling_refactor:10655
4ad37cd2-5fec-0310-835f-b3785c72a374:/Catalyst-Runtime/5.80/trunk:11345
4ad37cd2-5fec-0310-835f-b3785c72a374:/branches/Catalyst-ChildOf:4443
4ad37cd2-5fec-0310-835f-b3785c72a374:/branches/Catalyst-Runtime-jrockway:5857
4ad37cd2-5fec-0310-835f-b3785c72a374:/branches/Catalyst-component-setup:4320
4ad37cd2-5fec-0310-835f-b3785c72a374:/branches/Catalyst-docs:4325
4ad37cd2-5fec-0310-835f-b3785c72a374:/branches/current/Catalyst-Runtime:5142
4ad37cd2-5fec-0310-835f-b3785c72a374:/trunk/Catalyst:4483
4ad37cd2-5fec-0310-835f-b3785c72a374:/trunk/Catalyst-Runtime:6165
8a9521aa-ff93-41d6-9f87-b05cafcdab40:/local/cat/Catalyst-Runtime/5.80/trunk:8157
d7608cd0-831c-0410-93c0-e5b306c3c028:/local/Catalyst/Catalyst-Runtime:8339
d7608cd0-831c-0410-93c0-e5b306c3c028:/local/Catalyst/Catalyst-Runtime-jrockway:8342
e56d974f-7718-0410-8b1c-b347a71765b2:/local/Catalyst-Runtime:6511
e56d974f-7718-0410-8b1c-b347a71765b2:/local/Catalyst-Runtime-current:10442

Modified: Catalyst-Runtime/5.80/branches/deprecate_appclass_actions/Changes
===================================================================
--- Catalyst-Runtime/5.80/branches/deprecate_appclass_actions/Changes	2009-09-10 00:13:56 UTC (rev 11345)
+++ Catalyst-Runtime/5.80/branches/deprecate_appclass_actions/Changes	2009-09-10 01:11:49 UTC (rev 11346)
@@ -1,5 +1,15 @@
 # This file documents the revision history for Perl extension Catalyst.
+#
 
+    - Add allow_mutable_ancestors option when force inlining a constructor onto
+      applications with plugins defining their own (usually Class::Accessor::Fast)
+      new methods, to avoid warnings generated by upcoming Moose releases
+      as we can make a class (MyApp) immutable when not all of it's superclasses
+      (e.g. plugins not fully Moose converted, but using
+       MooseX::Emulate::Class::Accessor::Fast) are not immutable.
+
+5.80012 2009-09-09 19:09:09
+
   Bug fixes:
      - Fix t/optional_http-server.t test.
      - Fix t/optional_http-server-restart.t test.

Modified: Catalyst-Runtime/5.80/branches/deprecate_appclass_actions/lib/Catalyst/Runtime.pm
===================================================================
--- Catalyst-Runtime/5.80/branches/deprecate_appclass_actions/lib/Catalyst/Runtime.pm	2009-09-10 00:13:56 UTC (rev 11345)
+++ Catalyst-Runtime/5.80/branches/deprecate_appclass_actions/lib/Catalyst/Runtime.pm	2009-09-10 01:11:49 UTC (rev 11346)
@@ -7,7 +7,7 @@
 
 # Remember to update this in Catalyst as well!
 
-our $VERSION='5.80011';
+our $VERSION='5.80012';
 
 $VERSION = eval $VERSION;
 

Modified: Catalyst-Runtime/5.80/branches/deprecate_appclass_actions/lib/Catalyst.pm
===================================================================
--- Catalyst-Runtime/5.80/branches/deprecate_appclass_actions/lib/Catalyst.pm	2009-09-10 00:13:56 UTC (rev 11345)
+++ Catalyst-Runtime/5.80/branches/deprecate_appclass_actions/lib/Catalyst.pm	2009-09-10 01:11:49 UTC (rev 11346)
@@ -79,7 +79,7 @@
 
 # Remember to update this in Catalyst::Runtime as well!
 
-our $VERSION = '5.80011';
+our $VERSION = '5.80012';
 
 {
     my $dev_version = $VERSION =~ /_\d{2}$/;
@@ -1134,8 +1134,10 @@
                 . "Class::Accessor(::Fast)?\nPlease pass "
                 . "(replace_constructor => 1)\nwhen making your class immutable.\n";
         }
-        $meta->make_immutable(replace_constructor => 1)
-            unless $meta->is_immutable;
+        $meta->make_immutable(
+            replace_constructor => 1,
+            allow_mutable_ancestors => 1,
+        ) unless $meta->is_immutable;
     };
 
     $class->setup_finalize;
@@ -2806,6 +2808,8 @@
 
 Geoff Richards
 
+groditi: Guillermo Roditi <groditi at gmail.com>
+
 hobbs: Andrew Rodland <andrew at cleverdomain.org>
 
 ilmari: Dagfinn Ilmari Mannsåker <ilmari at ilmari.org>

Modified: Catalyst-Runtime/5.80/branches/deprecate_appclass_actions/t/aggregate/live_engine_request_escaped_path.t
===================================================================
--- Catalyst-Runtime/5.80/branches/deprecate_appclass_actions/t/aggregate/live_engine_request_escaped_path.t	2009-09-10 00:13:56 UTC (rev 11345)
+++ Catalyst-Runtime/5.80/branches/deprecate_appclass_actions/t/aggregate/live_engine_request_escaped_path.t	2009-09-10 01:11:49 UTC (rev 11346)
@@ -54,8 +54,6 @@
 }
 
 # test that request with URL-escaped code works.
-TODO: {
-    local $TODO = 'Actions should match when path parts are url encoded';
     my $request = Catalyst::Utils::request( 'http://localhost/args/param%73/one/two' );
     my $cgi     = HTTP::Request::AsCGI->new( $request, %ENV )->setup;
 
@@ -67,6 +65,8 @@
     TestApp->handle_request( env => \%ENV );
 
     ok( my $response = $cgi->restore->response );
+TODO: {
+    local $TODO = 'Actions should match when path parts are url encoded';
     ok( $response->is_success, 'Response Successful 2xx' );
     is( $response->content, 'onetwo' );
 }




More information about the Catalyst-commits mailing list