[Catalyst-commits] r11380 - in Catalyst-Runtime/5.80/branches/better_scripts/t: . lib

t0m at dev.catalyst.perl.org t0m at dev.catalyst.perl.org
Thu Sep 17 22:10:46 GMT 2009


Author: t0m
Date: 2009-09-17 22:10:46 +0000 (Thu, 17 Sep 2009)
New Revision: 11380

Added:
   Catalyst-Runtime/5.80/branches/better_scripts/t/unit_core_script_server.t
Modified:
   Catalyst-Runtime/5.80/branches/better_scripts/t/lib/TestAppToTestScripts.pm
Log:
Meh, that shows what I mean. This can be done waaaay more elegantly by abstracting the testing logic..

Modified: Catalyst-Runtime/5.80/branches/better_scripts/t/lib/TestAppToTestScripts.pm
===================================================================
--- Catalyst-Runtime/5.80/branches/better_scripts/t/lib/TestAppToTestScripts.pm	2009-09-17 21:47:22 UTC (rev 11379)
+++ Catalyst-Runtime/5.80/branches/better_scripts/t/lib/TestAppToTestScripts.pm	2009-09-17 22:10:46 UTC (rev 11380)
@@ -1,12 +1,12 @@
 package TestAppToTestScripts;
 use strict;
 use warnings;
+use Carp;
 
-our %RUN_ARGS;
+our @RUN_ARGS;
 
 sub run {
-    my ($class, %opts) = @_;
-    %RUN_ARGS = %opts;
+    @RUN_ARGS = @_;
     1; # Does this work?
 }
 

Added: Catalyst-Runtime/5.80/branches/better_scripts/t/unit_core_script_server.t
===================================================================
--- Catalyst-Runtime/5.80/branches/better_scripts/t/unit_core_script_server.t	                        (rev 0)
+++ Catalyst-Runtime/5.80/branches/better_scripts/t/unit_core_script_server.t	2009-09-17 22:10:46 UTC (rev 11380)
@@ -0,0 +1,46 @@
+use strict;
+use warnings;
+
+use FindBin qw/$Bin/;
+use lib "$Bin/lib";
+
+use Test::More 'no_plan';
+use Test::Exception;
+
+use Catalyst::Script::Server;
+
+{
+    local @ARGV; # Blank
+    local @TestAppToTestScripts::RUN_ARGS;
+    lives_ok {
+        Catalyst::Script::Server->new_with_options(application_name => 'TestAppToTestScripts')->run;
+    };
+    is_deeply \@TestAppToTestScripts::RUN_ARGS, ['TestAppToTestScripts',
+          '3000',
+          'localhost',
+          {
+            'pidfile' => undef,
+            'fork' => undef,
+            'follow_symlinks' => undef,
+            'background' => undef,
+            'keepalive' => undef
+          }];
+}
+
+{
+    local @ARGV = qw/-p 3001/;
+    local @TestAppToTestScripts::RUN_ARGS;
+    lives_ok {
+        Catalyst::Script::Server->new_with_options(application_name => 'TestAppToTestScripts')->run;
+    };
+    is_deeply \@TestAppToTestScripts::RUN_ARGS, ['TestAppToTestScripts',
+          '3001',
+          'localhost',
+          {
+            'pidfile' => undef,
+            'fork' => undef,
+            'follow_symlinks' => undef,
+            'background' => undef,
+            'keepalive' => undef
+          }];
+}




More information about the Catalyst-commits mailing list