[Catalyst-commits] r13151 - in Catalyst-Runtime/5.80/trunk: . lib lib/Catalyst/Engine t/aggregate

[t0m at dev.catalyst.perl.org]

Author: t0m
Date: 2010-04-12 20:16:39 +0100 (Mon, 12 Apr 2010)
New Revision: 13151

Modified:
   Catalyst-Runtime/5.80/trunk/Changes
   Catalyst-Runtime/5.80/trunk/lib/Catalyst.pm
   Catalyst-Runtime/5.80/trunk/lib/Catalyst/Engine/CGI.pm
   Catalyst-Runtime/5.80/trunk/t/aggregate/unit_core_engine_cgi-prepare_path.t
Log:
Fix dsadinoff's mod_rewrite bug I hope

Modified: Catalyst-Runtime/5.80/trunk/Changes
===================================================================
--- Catalyst-Runtime/5.80/trunk/Changes	2010-04-11 17:01:09 UTC (rev 13150)
+++ Catalyst-Runtime/5.80/trunk/Changes	2010-04-12 19:16:39 UTC (rev 13151)
@@ -1,5 +1,10 @@
 # This file documents the revision history for Perl extension Catalyst.
 
+  Bug fixes:
+   - Additional fix for getting the base application path right when rewriting
+     requests into an application sub path with mod_alias and mod_rewrite on
+     Apache.
+
   New features:
    - Setting __PACKAGE__->config(enable_catalyst_header => 1); in your MyApp.pm
      now enables the X-Catalyst header being printed when not in debug mode.

Modified: Catalyst-Runtime/5.80/trunk/lib/Catalyst/Engine/CGI.pm
===================================================================
--- Catalyst-Runtime/5.80/trunk/lib/Catalyst/Engine/CGI.pm	2010-04-11 17:01:09 UTC (rev 13150)
+++ Catalyst-Runtime/5.80/trunk/lib/Catalyst/Engine/CGI.pm	2010-04-12 19:16:39 UTC (rev 13151)
@@ -128,6 +128,7 @@
     else {
         $base_path = $script_name || '/';
     }
+#    $base_path .= '/' unless $base_path =~ m{/$};
 
     # If we are running as a backend proxy, get the true hostname
   PROXY_CHECK:
@@ -157,20 +158,15 @@
     if (my $req_uri = $ENV{REQUEST_URI}) {
         $req_uri =~ s/^\Q$base_path\E//;
         $req_uri =~ s/\?.*$//;
-        if ($req_uri) {
-            # Note that if REQUEST_URI doesn't start with a /, then the user
-            # is probably using mod_rewrite or something to rewrite requests
-            # into a sub-path of their application..
+        if ($req_uri && $req_uri ne '/') {
             # This means that REQUEST_URI needs information from PATH_INFO
             # prepending to it to be useful, otherwise the sub path which is
             # being redirected to becomes the app base address which is
             # incorrect.
-            if (substr($req_uri, 0, 1) ne '/') {
-                my ($match) = $req_uri =~ m|^([^/]+)|;
-                my ($path_info_part) = $path_info =~ m|^(.*?\Q$match\E)|;
-                substr($req_uri, 0, length($match), $path_info_part)
-                    if $path_info_part;
-            }
+            my ($match) = $req_uri =~ m{^(/?[^/]+)};
+            my ($path_info_part) = $path_info =~ m|^(.*?\Q$match\E)|;
+            substr($req_uri, 0, length($match), $path_info_part)
+                if $path_info_part;
             $path_info = $req_uri;
         }
     }

Modified: Catalyst-Runtime/5.80/trunk/lib/Catalyst.pm
===================================================================
--- Catalyst-Runtime/5.80/trunk/lib/Catalyst.pm	2010-04-11 17:01:09 UTC (rev 13150)
+++ Catalyst-Runtime/5.80/trunk/lib/Catalyst.pm	2010-04-12 19:16:39 UTC (rev 13151)
@@ -95,6 +95,7 @@
         my @superclasses = ($meta->superclasses, $class, 'Catalyst::Controller');
         $meta->superclasses(@superclasses);
     }
+    $meta->make_mutable if $meta->is_immutable; # HACK
     # Avoid possible C3 issues if 'Moose::Object' is already on RHS of MyApp
     $meta->superclasses(grep { $_ ne 'Moose::Object' } $meta->superclasses);
 

Modified: Catalyst-Runtime/5.80/trunk/t/aggregate/unit_core_engine_cgi-prepare_path.t
===================================================================
--- Catalyst-Runtime/5.80/trunk/t/aggregate/unit_core_engine_cgi-prepare_path.t	2010-04-11 17:01:09 UTC (rev 13150)
+++ Catalyst-Runtime/5.80/trunk/t/aggregate/unit_core_engine_cgi-prepare_path.t	2010-04-12 19:16:39 UTC (rev 13151)
@@ -86,9 +86,18 @@
     is ''.$r->base, 'http://www.foo.com/oslobilder/';
 }
 
+{
+    my $r = get_req (
+        PATH_INFO => '/auth/login',
+        SCRIPT_NAME => '/tx',
+        REQUEST_URI => '/login',
+    );
+    is ''.$r->path, 'auth/login';
+    is ''.$r->uri, 'http://www.foo.com/tx/auth/login';
+    is ''.$r->base, 'http://www.foo.com/tx/';
+}
 
 
-
 # FIXME - Test proxy logic
 #       - Test query string
 #       - Test non standard port numbers