[Catalyst-commits] r12851 - in HTTP-Request-AsCGI/trunk: . t

t0m at dev.catalyst.perl.org t0m at dev.catalyst.perl.org
Tue Feb 9 03:23:25 GMT 2010


Author: t0m
Date: 2010-02-09 03:23:23 +0000 (Tue, 09 Feb 2010)
New Revision: 12851

Modified:
   HTTP-Request-AsCGI/trunk/Changes
   HTTP-Request-AsCGI/trunk/t/05env.t
Log:
Fix RT#52456 - skip tests if we don't have Encode

Modified: HTTP-Request-AsCGI/trunk/Changes
===================================================================
--- HTTP-Request-AsCGI/trunk/Changes	2010-02-09 03:10:57 UTC (rev 12850)
+++ HTTP-Request-AsCGI/trunk/Changes	2010-02-09 03:23:23 UTC (rev 12851)
@@ -1,5 +1,8 @@
 This file documents the revision history for Perl extension HTTP::Request::AsCGI.
 
+    - Fixed tests on perl <= 5.6.2 by skipping if Encode is not installed.
+      (RT#52456)
+
 1.2 2010-01-12
     - Fixed the %ENV concatenation that's broken in 1.1 but wasn't shipped to CPAN (miyagawa)
     - REQUEST_URI is trying to replicate as raw values as possible, without being canonicalized (miyagawa)

Modified: HTTP-Request-AsCGI/trunk/t/05env.t
===================================================================
--- HTTP-Request-AsCGI/trunk/t/05env.t	2010-02-09 03:10:57 UTC (rev 12850)
+++ HTTP-Request-AsCGI/trunk/t/05env.t	2010-02-09 03:23:23 UTC (rev 12851)
@@ -1,14 +1,21 @@
 #!perl
 
-use Test::More tests => 11;
+use Test::More;
 
 use strict;
 use warnings;
 
+BEGIN {
+    eval { require Encode }
+        or plan skip_all => 'This test requires Encode';
+}
+
 use HTTP::Request;
 use HTTP::Request::AsCGI;
 use Encode;
 
+plan tests => 11;
+
 $ENV{__PRESERVE_ENV_TEST} = 1;
 
 my $r = HTTP::Request->new( GET => 'http://www.host.com/cgi-bin/script.cgi/my%20path%2F?a=1&b=2', [ 'X-Test' => 'Test' ] );




More information about the Catalyst-commits mailing list