[Catalyst-commits] r12656 - in Catalyst-Runtime/5.80/trunk: lib/Catalyst t/aggregate

[karpet at dev.catalyst.perl.org]

Author: karpet
Date: 2010-01-15 06:35:30 +0000 (Fri, 15 Jan 2010)
New Revision: 12656

Modified:
   Catalyst-Runtime/5.80/trunk/lib/Catalyst/Component.pm
   Catalyst-Runtime/5.80/trunk/t/aggregate/unit_core_component.t
Log:
in what case is a numeric comparison called for? I cannot think of one. Is this the best way to test?

Modified: Catalyst-Runtime/5.80/trunk/lib/Catalyst/Component.pm
===================================================================
--- Catalyst-Runtime/5.80/trunk/lib/Catalyst/Component.pm	2010-01-14 23:52:44 UTC (rev 12655)
+++ Catalyst-Runtime/5.80/trunk/lib/Catalyst/Component.pm	2010-01-15 06:35:30 UTC (rev 12656)
@@ -84,7 +84,7 @@
         } elsif (Class::MOP::is_class_loaded($_[0]) &&
                 $_[0]->isa('Catalyst') && ref($_[1]) eq 'HASH') {
             $args = $_[1];
-        } elsif ($_[0] == $_[1]) {
+        } elsif ($_[0] eq $_[1]) {
             $args = $_[1];
         } else {
             $args = +{ @_ };

Modified: Catalyst-Runtime/5.80/trunk/t/aggregate/unit_core_component.t
===================================================================
--- Catalyst-Runtime/5.80/trunk/t/aggregate/unit_core_component.t	2010-01-14 23:52:44 UTC (rev 12655)
+++ Catalyst-Runtime/5.80/trunk/t/aggregate/unit_core_component.t	2010-01-15 06:35:30 UTC (rev 12656)
@@ -1,4 +1,4 @@
-use Test::More tests => 22;
+use Test::More tests => 23;
 use strict;
 use warnings;
 
@@ -91,3 +91,18 @@
     is_deeply($args, [qw/foo3 bar3/], 'args passed to ACCEPT_CONTEXT ok');
 }
 
+# BUILDARGS logic
+{
+    {
+        package MyController;
+        @MyController::ISA = ('Catalyst::Controller');
+    }
+    my $warning;
+    local $SIG{__WARN__} = sub {
+        $warning = shift;
+        diag($warning);
+    };
+    my $controller = MyController->new('MyApp', undef);
+    like( $warning, qr/uninitialized value in string eq/, "no warning for == comparison");
+
+}