[Catalyst-commits] r13445 - in Catalyst-Runtime/5.80/branches/rt58057: . lib/Catalyst

[t0m at dev.catalyst.perl.org]

Author: t0m
Date: 2010-07-28 23:00:05 +0100 (Wed, 28 Jul 2010)
New Revision: 13445

Modified:
   Catalyst-Runtime/5.80/branches/rt58057/Changes
   Catalyst-Runtime/5.80/branches/rt58057/lib/Catalyst/Controller.pm
Log:
Document the horrible, changelog. I'm going to merge this and fix a real issue as I don't have time to fuck around inside Moose right now and it's been waiting way too long already

Modified: Catalyst-Runtime/5.80/branches/rt58057/Changes
===================================================================
--- Catalyst-Runtime/5.80/branches/rt58057/Changes	2010-07-28 21:56:25 UTC (rev 13444)
+++ Catalyst-Runtime/5.80/branches/rt58057/Changes	2010-07-28 22:00:05 UTC (rev 13445)
@@ -9,6 +9,8 @@
  Bug fixes:
   - Fix the --mech and --mechanize options to the myapp_create.pl script
     to operate correctly by fixing the options passed down into the script.
+  - Fix controllers with no method attributes (where the action definitions
+    are entirely contained in config). RT#58057
 
  Documentation:
   - Fix missing - in the docs when describing the --mechanize option at one

Modified: Catalyst-Runtime/5.80/branches/rt58057/lib/Catalyst/Controller.pm
===================================================================
--- Catalyst-Runtime/5.80/branches/rt58057/lib/Catalyst/Controller.pm	2010-07-28 21:56:25 UTC (rev 13444)
+++ Catalyst-Runtime/5.80/branches/rt58057/lib/Catalyst/Controller.pm	2010-07-28 22:00:05 UTC (rev 13445)
@@ -225,6 +225,8 @@
 
     foreach my $method (@methods) {
         my $name = $method->name;
+        # Horrible hack! All method metaclasses should have an attributes
+        # method, core Moose bug - see r13354.
         my $attributes = $method->can('attributes') ? $method->attributes : [];
         my $attrs = $self->_parse_attrs( $c, $name, @{ $attributes } );
         if ( $attrs->{Private} && ( keys %$attrs > 1 ) ) {