[Catalyst-commits] r13204 - in Catalyst-Controller-DBIC-Transaction/1.0/trunk: . lib/Catalyst/Action/DBIC lib/Catalyst/Controller/DBIC

[ruoso at dev.catalyst.perl.org]

Author: ruoso
Date: 2010-05-03 14:50:24 +0100 (Mon, 03 May 2010)
New Revision: 13204

Modified:
   Catalyst-Controller-DBIC-Transaction/1.0/trunk/Makefile.PL
   Catalyst-Controller-DBIC-Transaction/1.0/trunk/lib/Catalyst/Action/DBIC/Transaction.pm
   Catalyst-Controller-DBIC-Transaction/1.0/trunk/lib/Catalyst/Controller/DBIC/Transaction.pm
Log:
[C-C-DBIC-Transaction] Note the module as deprecated suggesting proper model encapsulation instead

Modified: Catalyst-Controller-DBIC-Transaction/1.0/trunk/Makefile.PL
===================================================================
--- Catalyst-Controller-DBIC-Transaction/1.0/trunk/Makefile.PL	2010-05-03 13:24:19 UTC (rev 13203)
+++ Catalyst-Controller-DBIC-Transaction/1.0/trunk/Makefile.PL	2010-05-03 13:50:24 UTC (rev 13204)
@@ -5,7 +5,7 @@
 WriteMakefile(
     NAME              => 'Catalyst::Controller::DBIC::Transaction',
     VERSION_FROM      => 'lib/Catalyst/Controller/DBIC/Transaction.pm', # finds $VERSION
-    PREREQ_PM         => { Catalyst::Runtime => 5.7011, Class::C3 => 0.20,
+    PREREQ_PM         => { Catalyst::Runtime => 5.7011, MRO::Compat => 0,
                            Sub::Name => 0},
     ($] >= 5.005 ?     ## Add these new keywords supported since 5.005
       (ABSTRACT_FROM  => 'lib/Catalyst/Controller/DBIC/Transaction.pm', # retrieve abstract from module

Modified: Catalyst-Controller-DBIC-Transaction/1.0/trunk/lib/Catalyst/Action/DBIC/Transaction.pm
===================================================================
--- Catalyst-Controller-DBIC-Transaction/1.0/trunk/lib/Catalyst/Action/DBIC/Transaction.pm	2010-05-03 13:24:19 UTC (rev 13203)
+++ Catalyst-Controller-DBIC-Transaction/1.0/trunk/lib/Catalyst/Action/DBIC/Transaction.pm	2010-05-03 13:50:24 UTC (rev 13204)
@@ -2,7 +2,8 @@
     use strict;
     use warnings;
     use base 'Catalyst::Action';
-    use Class::C3;
+    use MRO::Compat;
+    use mro 'c3';
     use Sub::Name 'subname';
 
     sub execute {
@@ -49,6 +50,11 @@
 
 =head1 DESCRIPTION
 
+THIS MODULE SHOULD BE CONSIDERED DEPRECATED. What is currently
+understood as a better practice is to enclose the code requiring a
+transaction into a proper model class. The point is that business
+logic should not be in the controller.
+
 This module enables the use of automatic transaction support into
 Catalyst Actions, it will associate a given action with the
 appropriate action class and save the DBIC::Schema model class name

Modified: Catalyst-Controller-DBIC-Transaction/1.0/trunk/lib/Catalyst/Controller/DBIC/Transaction.pm
===================================================================
--- Catalyst-Controller-DBIC-Transaction/1.0/trunk/lib/Catalyst/Controller/DBIC/Transaction.pm	2010-05-03 13:24:19 UTC (rev 13203)
+++ Catalyst-Controller-DBIC-Transaction/1.0/trunk/lib/Catalyst/Controller/DBIC/Transaction.pm	2010-05-03 13:50:24 UTC (rev 13204)
@@ -4,7 +4,7 @@
     use warnings;
     use base 'Catalyst::Controller';
 
-    our $VERSION = '0.3';
+    our $VERSION = '0.4';
 
     __PACKAGE__->mk_accessors qw(_dbic_transaction_schemas);
 
@@ -35,6 +35,11 @@
 
 =head1 DESCRIPTION
 
+THIS MODULE SHOULD BE CONSIDERED DEPRECATED. What is currently
+understood as a better practice is to enclose the code requiring a
+transaction into a proper model class. The point is that business
+logic should not be in the controller.
+
 This module enables the use of automatic transaction support into
 Catalyst Actions, it will associate a given action with the
 appropriate action class and save the DBIC::Schema model class name