[Catalyst-dev] [PATCH] File::Slurp not required in Makefile.PL

[Steve Peters]

On Thu, Nov 09, 2006 at 08:11:29AM +0100, Marcello Romani wrote:
> Steve Peters ha scritto:
> >I attempted to install Catalyst on a fresh Perl system and it failed two
> >tests:  optional_lighttpd-fastcgi-non-root.t and 
> >optional_lighttpd-fastcgi.t.
> >The failures were caused by File::Slurp being used, but never mentioned
> >in the Makefile.PL as a requirement.  The patch below adds it as a 
> >requirement.
> >
> >Steve Peters
> >steve at fisharerojo.org
> > 
> >--- Makefile.PL.old     2006-11-08 20:27:53.000000000 -0600
> >+++ Makefile.PL 2006-11-08 20:28:19.000000000 -0600
> >@@ -13,6 +13,7 @@
> > requires 'CGI::Simple::Cookie';
> > requires 'Data::Dump';
> > requires 'File::Modified';
> >+requires 'File::Slurp';
> > requires 'HTML::Entities';
> > requires 'HTTP::Body'    => '0.5';
> > requires 'HTTP::Headers' => '1.64';
> >
> >_______________________________________________
> >Catalyst-dev mailing list
> >Catalyst-dev at lists.rawmode.org
> >http://lists.rawmode.org/mailman/listinfo/catalyst-dev
> >
> >
> 
> File::Slurp is a requirement only if those tests are to be run.
> AFAIK, there's a patch in trunk that corrects the problem:
> 
> http://dev.catalyst.perl.org/changeset/5440
> 

This doesn't appear to be the case any more.  File::Slurp is use'd into
those files.  Since use is called at compile time instead of run time,
you have to have File::Slurp installed for the file the tests to not
fail.

http://search.cpan.org/src/MRAMBERG/Catalyst-Runtime-5.7005/t/optional_lighttpd-fastcgi-non-root.t

Steve Peters
steve at fisharerojo.org