[Catalyst-dev] file upload bug - patch attached

Carl Franks fireartist at gmail.com
Fri Nov 17 15:01:52 GMT 2006


If I submit a form containing both a textfield and a file-upload
field, which both have the name 'foo' ...

With CGI.pm, $q->param('foo') gives me:
[
  'textfield value',
  *blessed_filename,
]

With Catalyst, $c->req->param('foo') only gives:
'filename'

This is because uploads are processed after other parameters and
stomps on existing values.
The attached patch fixes it ( includes tests :)
It would now return this:
[
  'textfield value',
  'filename',
]

Carl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: file-upload.patch
Type: text/x-patch
Size: 3492 bytes
Desc: not available
Url : http://lists.scsys.co.uk/pipermail/catalyst-dev/attachments/20061117/=
5b0b6de9/file-upload.bin


More information about the Catalyst-dev mailing list