[Catalyst-dev] [Catalyst] patch: C::P::Compress::Deflate

Jonathan Rockway jon at jrock.us
Tue Sep 19 17:32:41 CEST 2006


> +    # skip if we have a particular browser type
> +    if (    $c->request->browser
> +        and $c->request->browser->windows
> +        and $c->request->browser->ie
> +        and $c->request->browser->major() <
> +        ( $c->config->{compress}->{skip_ie} || 0 ) )

Unless I'm missing something, these are going to blow up (throw an
exception) if you don't have C::P::Browser.  I think you should try
calling can first:

if ($c->request->can('browser')->() && ...

Regards,
Jonathan Rockway

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 368 bytes
Desc: OpenPGP digital signature
Url : http://lists.rawmode.org/pipermail/catalyst-dev/attachments/20060919/f9d4b64d/attachment.pgp 


More information about the Catalyst-dev mailing list