[Catalyst-dev] PATCH for Catalyst::Plugin::ConfigLoader

Brian Cassidy brian.cassidy at nald.ca
Tue Aug 21 15:17:58 GMT 2007


Greg Sheard wrote:
> ConfigLoader seems to use regexps that are too limited in 
> finalize_config. This means that when passing View::TT an INCLUDE_PATH 
> with more than one path specified (such as 
> "__HOME__/template:__HOME__/template2"), only the first __HOME__ is 
> substituted. Attached is a patch to handle this case, and the identical 
> case for using __path_to(some/path)__.

Thanks! Applied, except for one small change:

> +            s{__path_to\((.+)\)__}{ $c->path_to( split( '/', $1 ) ) }eg;

is now:

s{__path_to\((.+?)\)__}{ $c->path_to( split( '/', $1 ) ) }eg;

so that the .+ is non-greedy.

-Brian



More information about the Catalyst-dev mailing list