[Catalyst-dev] [PATCH] Catalyst::Manual - POD Typos and a Correction for a Tutorial Fact

[Shlomi Fish]

On Thursday 12 July 2007, Kieren Diment wrote:
> Apologies.  I applied the parts of the patch that were typos, but I
> had trouble with the other parts.  There may have been corrections to
> errors there but they were comingled with things that were purely
> subjective style improvements, so I dropped these.  It didn't seem to
> be worth while pursuing it further at the time for a variety of
> reasons.
>

Here's something you missed - "when you are done" appears in one sentence =

twice. This patchlet corrects it.

Oh and you should populate svn:ignore appropriately there, as at the moment =

there are a lot of "?" files.

And the corrections that weren't applied, was trying to correct the =

description of the behaviour that occured after following the tutorial. As =
I =

could tell, it didn't behave the way the tutorial described and it was =

evident from the code that was introduced there.

Regards,

	Shlomi Fish

> On 12/07/07, Shlomi Fish <shlomif at iglu.org.il> wrote:
> > Hi all!
> >
> > On Friday 22 June 2007, Shlomi Fish wrote:
> > > Hi all!
> > >
> > > I've been following the Catalyst tutorial and found a few errors. The
> > > attached patch aims to fix them. It is also available at:
> > >
> > > http://www.shlomifish.org/Files/files/code/perl/catalyst/
> > >
> > > I hereby disclaim any implicit or explicit copyrights for the patch,
> > > and put my contributions under the Public Domain. Crediting me would =
be
> > > appreciated, but not absolutely necessary.
> >
> > This is a reminder that I submitted this patch about three weeks ago, a=
nd
> > did not receive any input on it.
> >
> > Regards,
> >
> >         Shlomi Fish
> >
> > > Regards,
> > >
> > >       Shlomi Fish
> > >
> > > ---------------------------------------------------------------------
> > > Shlomi Fish      shlomif at iglu.org.il
> > > Homepage:        http://www.shlomifish.org/
> > >
> > > If it's not in my E-mail it doesn't happen. And if my E-mail is saying
> > > one thing, and everything else says something else - E-mail will
> > > conquer. -- An Israeli Linuxer
> >
> > --
> >
> > ---------------------------------------------------------------------
> > Shlomi Fish      shlomif at iglu.org.il
> > Homepage:        http://www.shlomifish.org/
> >
> > If it's not in my E-mail it doesn't happen. And if my E-mail is saying
> > one thing, and everything else says something else - E-mail will conque=
r.
> >     -- An Israeli Linuxer
> >
> > _______________________________________________
> > Catalyst-dev mailing list
> > Catalyst-dev at lists.rawmode.org
> > http://lists.rawmode.org/mailman/listinfo/catalyst-dev
>
> _______________________________________________
> Catalyst-dev mailing list
> Catalyst-dev at lists.rawmode.org
> http://lists.rawmode.org/mailman/listinfo/catalyst-dev



-- =


---------------------------------------------------------------------
Shlomi Fish      shlomif at iglu.org.il
Homepage:        http://www.shlomifish.org/

If it's not in my E-mail it doesn't happen. And if my E-mail is saying
one thing, and everything else says something else - E-mail will conquer.
    -- An Israeli Linuxer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: when-you-are-done.diff
Type: text/x-diff
Size: 535 bytes
Desc: not available
Url : http://lists.scsys.co.uk/pipermail/catalyst-dev/attachments/20070712/=
25322e6d/when-you-are-done.bin