[Catalyst-dev] [Patch] Catalyst::View::Email configuration

[J. Shirley]

On 7/12/07, J. Shirley <jshirley at gmail.com> wrote:
> On 7/11/07, Daniel Westermann-Clark <dwc at pobox.com> wrote:
> > Hi,
> >
> > I was playing around with Catalyst::View::Email and ran into some
> > problems configuring it via a configuration file (as opposed to
> > __PACKAGE__->config).
> >
> > The problem was that View::Email was not storing the configuration
> > passed in from ConfigLoader.  The attached patch simply stores the
> > configuration at the beginning of new.  (This seems to be a relatively
> > common idiom, but I'd be happy to correct it if it's wrong.)  There
> > are some additional tests to verify this behavior.
> >
> > I also made a couple of minor POD updates.  There were two places
> > where example code was not separated from the text, making the output
> > (on search.cpan.org at least) confusing.  I also updated the bit about
> > the default_view option; the key in the example did not match the
> > code.
> >
> > Other than that, Email::View has been a cinch to use... Thanks!
> >
> > --
> > Daniel Westermann-Clark
> >
>
> Thanks, I'll get this applied today!
>
> -Jay
>

Patched, and 0.02 is out to CPAN.  Thanks again Daniel!

-- 
J. Shirley :: jshirley at gmail.com :: Killing two stones with one bird...
http://www.toeat.com