[Catalyst-dev] Fix for system() returning -1 on dev server

[Matt S Trout]

On Fri, Oct 26, 2007 at 01:03:51PM +0930, Jon Schutz wrote:
> That system() returns -1 while running on the Catalyst::Engine::HTTP
> server seems to be a well known fact and was discussed on the list a
> year ago (didn't stop the bug biting me again but).
> 
> I have traced the cause to HTTP.pm, line 191 or thereabouts:
> 
>     local $SIG{CHLD} = 'IGNORE';
> 
> Getting rid of this line, or setting $SIG{CHLD} to a proper child reaper
> handler, fixes the problem with system().  

Go find the changeset where we switched it to his, and the previous mail
threads, and explain why this won't re-introduce the problems that caused
us to move to IGNORE in the first place.

Also, your patch has no tests.

Both need to happen before it goes into a production release, or at the very
least it needs tests and to be pushed to 5.80.

-- 
      Matt S Trout       Need help with your Catalyst or DBIx::Class project?
   Technical Director                    http://www.shadowcat.co.uk/catalyst/
 Shadowcat Systems Ltd.  Want a managed development or deployment platform?
http://chainsawblues.vox.com/            http://www.shadowcat.co.uk/servers/