[Catalyst-dev] PATCH: factor out env quirks in C::E::FastCGI to _fix_env method and IIS env fix

Andy Grundman andy at hybridized.org
Mon Dec 1 13:00:06 GMT 2008


On Nov 27, 2008, at 4:05 PM, Simon Bertrang wrote:

> Hi,
> while deploying a Catalyst application on Windows (thanks to Evan
> Carroll!) i noticed that IIS has borked environment variables that  
> will
> prevent redirects and such from working because $c->req->base is
> completely wrong.
> This is caused by wrong PATH_INFO and SCRIPT_NAME which obviously  
> needs
> a workaround.
>
> With some feedback from t0m and other developers i even managed to
> assemble a test and furthermore factored the quirks from
> C::E::FastCGI::run() out into C::E::FastCGI::_fix_env() so all the  
> fixes
> are in one place and relatively easy to test and extend (jshirleys  
> recent
> nginx patch comes to mind).
>
> I've tested this on Windows 2003 with the app configured at the web  
> root
> and in virtual directories, all working fine.
>
> Please provide some feedback and let us know if it works for you so it
> can be eventually committed.

Thanks, your patch looks fine.  You might want to add another test for  
the lighttpd case, just to be complete.

-Andy



More information about the Catalyst-dev mailing list