[Catalyst-dev] patch for changes to Catalyst-Manual::Tutorial
Tomas Doran
bobtfish at bobtfish.net
Thu Jan 29 21:18:40 GMT 2009
On 29 Jan 2009, at 18:11, Del Merritt wrote:
> The patch was generated with "svn diff" from the Catalyst-Manual
> directory; I hope this is not too inconvenient. I was not willing
> to wait for svn's diff over the entire repository.
>
Applied!
http://dev.catalystframework.org/svnweb/Catalyst/revision?rev=9140
> Apologies in advance if:
<pedant mode="on">
> 1. the diff isn't of the proper format; #catalyst suggested it would
> be acceptable
Usually I'd diff from trunk, so you apply with -p0, but -p2 worked
just fine..
> 2. the form of attachment is annoying; please let me know how better
> to send/attach if this is a problem
Not a big issue, but inline means I have to save the mail and crop
the patch out, rather than just saving the patch, so if you can make
it an actual attachment that'd be slightly more convenient.
</pedant>
> 3. I've missed some other bit of catalyst-specific patch protocol
Nope, next step is stop by #catalyst-dev, and someone will give you a
commit bit to the Manual :_)
Good work, many thanks.
t0m
More information about the Catalyst-dev
mailing list