<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">I think I've done this right. Git is making me slightly crazy; I've been using Perforce for ten years, and there are things that feel similar but aren't.<div><br></div><div>I've submitted a pull request for the stopwords to get t/author/spelling.t fixed. Trivial, but it makes the tests pass.</div><div><br></div><div>I misremembered what it is I've been having to override Script/Server.pm to provide; it isn't an option for the hostname; there already is a -h option for that. It's an environment variable to set the hostname, like you can set the port number. I've got a change for that, too. Shall I send the pull request for that?<br><div><div><br><div><div>On Jun 25, 2014, at 8:35 PM, Louis Erickson <<a href="mailto:lerickson@rdwarf.net">lerickson@rdwarf.net</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Apparently "tonight" was optimistic, as that was nearly a month ago. I have finally submitted a pull request to you. It should be waiting for you in github.<div><br></div><div>There was one error before and after my changes - t/author/spelling.t failed. I'll probably submit a patch for that, too because having make test fail annoyed me.</div><div><br></div><div>In my environment, it's quite useful to have an additional option to the server as well, '-h' to select which hostname to use. Testing and winding up on the wrong interface is not my favorite. I've been adding that to each app, but it appears to me to be a pretty generic option. If I send along a pull request to add it, will you consider it? (I'll have to find the documentation, and update that, too.)<br><div><br><div><div>On Jun 2, 2014, at 2:25 PM, Louis Erickson <<a href="mailto:lerickson@rdwarf.net">lerickson@rdwarf.net</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On May 29, 2014, at 7:58 AM, John Napiorkowski <<a href="mailto:jjn1056@yahoo.com">jjn1056@yahoo.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="background-color: rgb(255, 255, 255); font-family: HelveticaNeue, 'Helvetica Neue', Helvetica, Arial, 'Lucida Grande', sans-serif; font-size: 12pt; position: static; z-index: auto;"><div class="" style=""><span class="" style="">Hey,</span></div><div style="font-size: 16px; font-family: HelveticaNeue, 'Helvetica Neue', Helvetica, Arial, 'Lucida Grande', sans-serif; background-color: transparent; font-style: normal;" class=""><span class="" style=""><br class="" style=""></span></div><div style="font-size: 16px; font-family: HelveticaNeue, 'Helvetica Neue', Helvetica, Arial, 'Lucida Grande', sans-serif; background-color: transparent; font-style: normal;" class=""><span class="" style="">Looks pretty good, any chance we could get a patch via github : <a href="https://github.com/perl-catalyst/catalyst-runtime" class="" style="">perl-catalyst/catalyst-runtime</a>?</span></div></div></blockquote><div><br></div><div>Happy to do so, if I can figure out how.</div><div><br></div><div>I didn't know Catalyst was using github. The Wiki <a href="http://wiki.catalystframework.org/wiki/contrib">points</a> to a git repository at shadowcat.</div><div><br></div><div>I've used github less than the rest of git; what's the preferred process to get you the patch? Their <a href="https://help.github.com/articles/using-pull-requests">documentation</a> suggests I fork, submit to my fork, then issue a "pull request"... is that what you need?</div><div><br></div><div>If so, I'll try that tonight.</div></div><br></div>_______________________________________________<br>Catalyst-dev mailing list<br><a href="mailto:Catalyst-dev@lists.scsys.co.uk">Catalyst-dev@lists.scsys.co.uk</a><br><a href="http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst-dev">http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst-dev</a><br></blockquote></div><br></div></div></div>_______________________________________________<br>Catalyst-dev mailing list<br><a href="mailto:Catalyst-dev@lists.scsys.co.uk">Catalyst-dev@lists.scsys.co.uk</a><br>http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst-dev<br></blockquote></div><br></div></div></div></body></html>