[Catalyst] Preferred format for doc patches?

[Allen S. Rout]

==> On Sat, 19 Nov 2005 18:57:08 +0100, Sebastian Riedel <sri at oook.de> said:


> Patches for trunk pls.

>      http://dev.catalyst.perl.org/repos/Catalyst/trunk

Aye, aye. Against:

http://dev.catalyst.perl.org/repos/Catalyst/trunk/HTML-Prototype/lib/HTML/Prototype.pm


At least for the form tag specifically limits the HTML options which can be
pasted in.  I patched it to let me apply a name to a form, but the W3C
specifies a rather longer list.

http://www.w3.org/TR/REC-html40/interact/forms.html#h-17.3

It might be worthwhile to add the entire vocabulary, as they are faculties
which some random user might reasonably expect to reach for.


[ already present ]
  action      %URI;          #REQUIRED -- server-side form handler --
  method      (GET|POST)     GET       -- HTTP method used to submit the form--
  onsubmit    %Script;       #IMPLIED  -- the form was submitted --

[ asr would like added ]
  name        CDATA          #IMPLIED  -- name of form for scripting --

[ other standard fields ]
  enctype     %ContentType;  "application/x-www-form-urlencoded"
  accept      %ContentTypes; #IMPLIED  -- list of MIME types for file upload --
  onreset     %Script;       #IMPLIED  -- the form was reset --
  accept-charset %Charsets;  #IMPLIED  -- list of supported charsets --



--- Prototype.pm        2005-11-19 16:24:05.000000000 -0500
+++ Prototype.edit.pm   2005-11-19 16:23:51.000000000 -0500
@@ -390,6 +390,7 @@
     $options->{html_options} ||= {};
     $options->{html_options}->{action} ||= $options->{url} || '#';
     $options->{html_options}->{method} ||= 'post';
+    $options->{name} && ($options->{html_options}->{name} = $options->{name});
     $options->{html_options}->{onsubmit} =
       _remote_function($options) . '; return false';
     return $self->tag( 'form', $options->{html_options}, 1 );




- Allen S. Rout