[Catalyst] Patch for Catalyst::Engine::Apache

[Bill Moseley]

On Thu, May 18, 2006 at 11:41:28PM -0400, Andy Grundman wrote:
> Sorry sorry. :)  Do you think this patch should apply to Engine::CGI
> as well (for FastCGI)?  The proxy check code should also probably be
> factored out somewhere so it's not duplicated in different engines.

Yes, I wondered about that too.  It would be much better in one place.

My little patch only really helps for debugging when using a port
like 8443, but otherwise normal ssl requests won't have the port in
the X-Forwared-Host header.

I though about using ProxyRequestHeader to set something like
X-Is-SSL, but I don't see that for Apache2's mod_proxy.

When Catalyst is behind a proxy and can handle ssl and non-ssl maybe
one way is to listen on two ports, and use the Host: header to match
on /443/ to detect a secure connection.  There's no $c->req->port,
right?

Well, there's also mod_proxy_html.

Hum, I wonder how all this will fit in with
Catalyst::Plugin::RequireSSL.

-- 
Bill Moseley
moseley at hank.org