[Catalyst] Follow-up to new uri_for() bug

Matt S Trout dbix-class at trout.me.uk
Tue Sep 12 03:22:54 CEST 2006

apv wrote:
> http://lists.rawmode.org/pipermail/catalyst/2006-September/ 
> 009531.html (I did start a new message there, blame Mail.app, not me  
> for the bad threading)
> Okay, mean guys. Make me solve my own, er, Catalyst's own, bugs.
> Line 118 (5.7001) of Catalyst::Engine::CGI looks like this:
>          $base_path =~ s/$ENV{PATH_INFO}$//;
> Unless I'm losing it, it should look like this:
>          $base_path =~ s/\Q$ENV{PATH_INFO}\E$//;
> Otherwise uri_for (well, request->base and anything that uses it)  
> gets borked by any number of regex chars in the URI.

That seems like a sane complaint.

If you can add a failing test I can get it into 5.70002 ...

      Matt S Trout       Offering custom development, consultancy and support
   Technical Director    contracts for Catalyst, DBIx::Class and BAST. Contact
Shadowcat Systems Ltd.  mst (at) shadowcatsystems.co.uk for more information

+ Help us build a better perl ORM: http://dbix-class.shadowcatsystems.co.uk/ +

More information about the Catalyst mailing list