[Catalyst] Uniform treatment of all parameters (including file uploads)

Matt S Trout dbix-class at trout.me.uk
Wed Jul 4 15:52:19 GMT 2007


On Wed, Jul 04, 2007 at 11:29:12AM +0000, Zbigniew Lukasiak wrote:
> On 7/3/07, Matt S Trout <dbix-class at trout.me.uk> wrote:
> >No, because this would break the ability to pass the request object to
> >something expecting the CGI.pm API, and break compat for existing app code.
> 
> I think you meant Apache::Request because the current implementation
> is not compatible with CGI.pm.

My mistake.

> >Maybe have a think about what you'd like to see from a completely new
> >unified API and propose that?
> 
> So my wishlist would be: ->upload to return the filehandle (for
> compatibility with CGI), ->param to return Catalyst::Request::Upload,
> and make Catalyst::Request::Upload stringify to the filename.  If we
> could also make Catalyst::Request::Upload work as a filehandle in
> angle brackets it would be entirely compatible with CGI.pm (but not
> with Apache::Request).

That looks like it'd improve compat, give you what you want, and not
break any existing code, unless I've misunderstood your logic. Assuming
I haven't, I'd love to see a patch to do this - does anybody else have
any thoughts?

-- 
      Matt S Trout       Need help with your Catalyst or DBIx::Class project?
   Technical Director    Want a managed development or deployment platform?
 Shadowcat Systems Ltd.  Contact mst (at) shadowcatsystems.co.uk for a quote
http://chainsawblues.vox.com/             http://www.shadowcatsystems.co.uk/ 



More information about the Catalyst mailing list