[Catalyst] setup_home() bug

Ashley apv at sedition.com
Fri Jul 20 23:22:42 GMT 2007


Great, you rule. Sorry about the wrap; Mail.app is full of unpleasant  
surprises lately. I'll try them as attachments this time.

-------------- next part --------------
--- Catalyst/Engine/CGI.pm.orig	2007-07-18 16:57:09.000000000 -0700
+++ Catalyst/Engine/CGI.pm	2007-07-18 16:57:24.000000000 -0700
@@ -115,7 +115,7 @@
     my $base_path;
     if ( exists $ENV{REDIRECT_URL} ) {
         $base_path = $ENV{REDIRECT_URL};
-        $base_path =~ s/$ENV{PATH_INFO}$//;
+        $base_path =~ s/\Q$ENV{PATH_INFO}\E$//;
     }
     else {
         $base_path = $ENV{SCRIPT_NAME} || '/';
-------------- next part --------------
A non-text attachment was scrubbed...
Name: live_engine_uri_for.t
Type: application/octet-stream
Size: 1195 bytes
Desc: not available
Url : http://lists.scsys.co.uk/pipermail/catalyst/attachments/20070720/1735f367/live_engine_uri_for.obj
-------------- next part --------------

On Jul 20, 2007, at 2:47 PM, Jonathan T. Rockway wrote:

> On Mon, Jul 09, 2007 at 04:53:18PM -0400, Adam Herzog wrote:
>>  Okay. I added Catalyst::Utils::env_value(), and updated Catalyst.pm
>>  Index: t/unit_utils_env_value.t
>>  Index: lib/Catalyst.pm
>>  Index: lib/Catalyst/Utils.pm
>
> Thanks for the patch, it looks great.  The only problem is that your
> mail client seems to have wrapped some long lines, and even when I
> manually fix it C<patch> is unable to apply the patch.
>
> If you could regenerate and send it unmunged, then I'll get this
> applied ASAP.
>
> Regards,
> Jonathan Rockway
>
> _______________________________________________
> List: Catalyst at lists.rawmode.org
> Listinfo: http://lists.rawmode.org/mailman/listinfo/catalyst
> Searchable archive: http://www.mail-archive.com/ 
> catalyst at lists.rawmode.org/
> Dev site: http://dev.catalyst.perl.org/



More information about the Catalyst mailing list