[Catalyst] Unnecessary session writes

Tomas Doran bobtfish at bobtfish.net
Wed Dec 17 08:34:36 GMT 2008

On 17 Dec 2008, at 05:11, Bill Moseley wrote:

> On Tue, Dec 16, 2008 at 06:20:43PM +0000, Tomas Doran wrote:
>> Do you fancy writing a test for the issue so we can actually prove  
>> it is
>> gone?
> Well, it would could be something like this:


Again looks perfectly reasonable to me :)

Apologies if I wasn't being clear perviously - could you convert your  
suggested changes and test into a diff against the distribution which  
someone could just apply with patch, rather than having to fiddle  
around copying chunks of code out of email?

> But, the plugin also always writes an "expires:" key into the store
> (hence the /^session:/ match above), so if the goal is to not write to
> the store unless there's something to store then that needs looking
> at, too.


If you'd like to include TODO tests for that in the patch (or just  
fix it, with no TODO in the test), then that would be fantastic.

As you've probably seen from the mailing list already, there are a  
couple of pending patches on Catalyst-Plugin-Session already:


It's easier to merge patches than chunks of changed code, but I think  
it's pretty open-season on getting niggles fixed in the Session  
plugin at the moment.  :)


More information about the Catalyst mailing list