[Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

Carl Franks fireartist at gmail.com
Wed Dec 17 15:30:02 GMT 2008


2008/12/17 Tomas Doran <bobtfish at bobtfish.net>:
>
> On 17 Dec 2008, at 14:52, Carl Franks wrote:
>>>
>>> Can you try trunk, as I think this issue is already fixed there?
>>
>> Confirmed working - many thanks.
>
> No problem.
>
> There isn't a failing test for this - I just changed it because it looked
> 'more right' and didn't break anything.
>
> Fancy attempting one (as there _should_ be one)?

Patch is attached.
Unfortunately the test framework already strips the filenames down to
the basename before POSTing, so we can't test that filename() and
basename() differ.

I noticed the warnings below while running
t/aggregate/live_engine_request_uploads.t
- don't really know what to make of them.
Upgrading to latest HTTP::Body didn't help.

Argument "9, 9" isn't numeric in subtraction (-) at
/home/cafranks/checkout/catalyst-5.0/t/../lib/Catalyst/Engine.pm line
567.
Argument "9, 9" isn't numeric in numeric gt (>) at
/opt/perl-5.10.0/lib/site_perl/5.10.0/HTTP/Body.pm line 192.
Argument "9, 9" isn't numeric in numeric eq (=3D=3D) at
/opt/perl-5.10.0/lib/site_perl/5.10.0/HTTP/Body/OctetStream.pm line
40.
Argument "9, 9" isn't numeric in subtraction (-) at
/home/cafranks/checkout/catalyst-5.0/t/../lib/Catalyst/Engine.pm line
567.
Argument "9, 9" isn't numeric in subtraction (-) at
/home/cafranks/checkout/catalyst-5.0/t/../lib/Catalyst/Engine.pm line
328.

Also, I got a test failure when I tried running `prove -lr t` - but no
failures when running `make test`.
Is that considered a problem?

Carl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: basename.patch
Type: application/octet-stream
Size: 1140 bytes
Desc: not available
Url : http://lists.scsys.co.uk/pipermail/catalyst/attachments/20081217/4f6c=
fe25/basename.obj


More information about the Catalyst mailing list