[Catalyst] [PATCH] [RFC] Override base URI

[Andrew Rodland]

On Friday 10 October 2008 02:04:44 pm Andrew Rodland wrote:
> On Friday 10 October 2008 01:21:14 pm Jason Kuri wrote:
> > Great work.  I was looking into this yesterday.   I'm glad you beat me
> > to it. :-)
> >
> > To follow up on Tomas' comment - Why not make the override_base_uri /
> > override_base_uri_secure include the schema?  So if you want the URI's
> > to include https:// even if the request is coming in not-secure, you
> > can do that.
> >
> > Without this functionality it would be hard to do SSL accelerators and
> > such properly.
>
> I was trying to be clever and make it so that you only needed one config
> key in the case where your secure and nonsecure bases only differed in the
> scheme. I guess it was too clever. I'll go back and make them entirely
> separate -- it'll be less code anyway. :)

New version based on input from t0m and jayk and karpet.

 lib/Catalyst/Engine/CGI.pm |   23 +++++++--
 t/unit_engine_cgi.t        |   86 +++++++++++++++++++++++++++++++++++
 2 files changed, 105 insertions(+), 4 deletions(-)

Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: override-base-uri-2.diff
Type: text/x-diff
Size: 3601 bytes
Desc: not available
Url : http://lists.scsys.co.uk/pipermail/catalyst/attachments/20081010/b365=
9d1a/override-base-uri-2.bin