[Catalyst] [PATCH] Catalyst::DispatchType::Chained (5.7101, 5.80001)

[Marcus Ramberg]

On Mon, Apr 20, 2009 at 9:23 PM, Oleg Kostyuk <cub.uanic at gmail.com> wrote:

> 2009/4/20 Matt S Trout <dbix-class at trout.me.uk>:
> > On Mon, Apr 20, 2009 at 05:16:55AM +0300, Oleg Kostyuk wrote:
> >> PS: probably, it's needed to check all other places, that use
> Text::SimpleTable
> >
> > That'd be well worth doing. Please send us a patch if you find any more
> when
> > you check them :)
>
> Sure, why not :)
>
> New patch attached. We need one more dependency to get this working,
> Text::SimpleTable::AutoWidth.
>
> Feel free to patch my patch :) by changing fixed_width to max_width
> and vice versa, if you think that that will looks better. Tables that
> created with "max_width" will be not wider than needed, and tables
> that created with "fixed_width" will be always all terminal wide.
>
> Any feedback welcome.


I don't think that was what Matt asked for. Anyways,

1) Why can't your changes be a patch to Text::SimpleTable?
2) Text::SimpleTable::AutoWidth uses Moose and Text::SimpleTable without
declaring so in the Makefile.PL

Marcus
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.scsys.co.uk/pipermail/catalyst/attachments/20090420/77143=
c3b/attachment.htm