[Catalyst] patch for C::P::Session::Store::Cookie

Tomas Doran bobtfish at bobtfish.net
Tue Jun 9 17:41:34 GMT 2009


Fayland Lam wrote:
> hey, it's a patch for Catalyst::Plugin::Session::Store::Cookie. to make 
> cookie_domain more configurable.
> 
>     __PACKAGE__->config->{session}->{cookie_domain} = sub {
>         my $c = shift;
>         if ( $c->req->uri->host =~ /xxx\.com/ ) {
>             return '.xxx.com <http://xxx.com>';
>         } else {
>             return '.yyy.com <http://yyy.com>';
>         }
>     };
> 
> if it's acceptable, I'll provide a .t for that.

Er, I don't see the value of putting code refs into config - that's 
fairly insane.. Code != config.

What are you actually trying to achieve here (i.e. what are some example 
use cases)?

But yes, patches to improve flexibility with tests would be generally 
welcome.

Cheers
t0m






More information about the Catalyst mailing list