[Catalyst] Catalyst-Authentication-Store-DBIx-Class-User v0.1400 - patch

Anthony Gladdish a.j.gladdish at newcastle.ac.uk
Wed Nov 17 14:53:58 GMT 2010


>-----Original Message-----
>From: Tomas Doran [mailto:bobtfish at bobtfish.net]
>Sent: 16 November 2010 15:41
>To: The elegant MVC web framework
>Cc: Anthony Gladdish
>Subject: Re: [Catalyst] Catalyst-Authentication-Store-DBIx-Class-User v0.1400
>- patch
>
>
>On 16 Nov 2010, at 15:28, Anthony Gladdish wrote:
>> The from_session() method has a call to load() with no $c param. It
>> did previously, and this change is breaking my own authentication
>> tests.
>> Catalyst-Authentication-Store-DBIx-Class 0.1400 test suite passes on
>> my attached patch, and my own authentication tests are now passing.
>>
>> Is there any reason why $c has been ommited here?
>
>No, it's a bug.
>
>> Can this patch be merged in please?
>
>Can you extract a test from your tests and add it to the patch?
>
>That'll stop the issue ever re-occurring..

Failing test case and it's patch attached.

Thanks,
Anthony
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Cat-Auth-Store-DBIC-0.1400.patch
Type: application/octet-stream
Size: 6998 bytes
Desc: Cat-Auth-Store-DBIC-0.1400.patch
Url : http://lists.scsys.co.uk/pipermail/catalyst/attachments/20101117/08654180/Cat-Auth-Store-DBIC-0.1400.obj


More information about the Catalyst mailing list