[Catalyst] [ANNOUNCE] Catalyst-Runtime-5.89002-TRIAL PSGI Catalyst - third development release

[Florian Ragwitz]

Pedro Melo <melo at simplicidade.org> writes:

> On Wed, Mar 2, 2011 at 3:27 PM, Florian Ragwitz <rafl at debian.org> wrote:
>
>> I'm not sure if this change of behaviour is something we should fix
>> though. The engine knows that a request is secure by checking
>> psgi.url_scheme, and applications can ask for that using
>> $ctx->request->secure. Similarly, the request host was, is, and probably
>> always will be available as $ctx->request->host.
>
> Right now I don't need https/secure, but I do need the host.
>
> At first I assumed that something like $ctx->request->host would be
> available but its not:
>
> [error] Caught exception in E5::Sites::Gestao::View::HTML->process
> "Can't locate object method "host" via package "Catalyst::Request"

Sorry, I meant to say $ctx->request->uri->host

>> Did these changes actually cause your app to break? If so, what
>> exactly does the code that broke look like?
>
> Yes, it did because the app switched template paths based on the
> hostname used to access the app.
>
> The code I was using was:
>
> my $host = $c->request->headers->header('Host');
> $host =~ s/:\d+$//;

I guess pretty much every webserver will set a Host header, so we should
probably do that as well in Plack::Test::MockHTTP, or at least in
Catalyst::Test::local_request only for back-compat. I'll see what Plack
upstream thinks about doing this in ::MockHTTP.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
Url : http://lists.scsys.co.uk/pipermail/catalyst/attachments/20110302/0f2714fb/attachment.pgp