Bump.<br><br>Anyone know the status of this feature? Even if it was available only as plugin it was would be incredibly useful.<br><br>Thanks,<br>GF<br><br><div class="gmail_quote">On Wed, Jul 1, 2009 at 11:26 AM, Brian Phillips <span dir="ltr"><<a href="mailto:bpphillips%2Bml@gmail.com">bpphillips+ml@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">OK, I'm seriously ruining my first attempt at submitting a patch. :-) I changed the capitalization of a config key without updating the unit tests so <blush> here's another patch file.<div>
<br></div><div>Apologies for the spam. I think this is the last one I'll need to post on this issue ... hopefully ... :-)<div><div></div><div class="h5"><br>
<br><div class="gmail_quote">On Wed, Jul 1, 2009 at 11:16 AM, Brian Phillips <span dir="ltr"><<a href="mailto:bpphillips%2Bml@gmail.com" target="_blank">bpphillips+ml@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Sorry for the repost but I realized I hadn't updated to svn HEAD before making the patch file. In case that matters, the attached should apply cleanly against r10759.<div><br></div><div>Thanks!<div><div></div><div>
<br><br><div class="gmail_quote">
On Wed, Jul 1, 2009 at 11:03 AM, Brian Phillips <span dir="ltr"><<a href="mailto:bpphillips%2Bml@gmail.com" target="_blank">bpphillips+ml@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
I've taken a stab at implementing this as I recently was wanting this functionality. See attached for the patch (including docs and unit tests). Feedback welcome.<div><div></div><div><div><div><br><div class="gmail_quote">
On Fri, Jan 30, 2009 at 5:20 PM, Byron Young <span dir="ltr"><<a href="mailto:Byron.Young@riverbed.com" target="_blank">Byron.Young@riverbed.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Tomas Doran wrote on 2009-01-29:<br>
<div><div></div><div>><br>
> On 29 Jan 2009, at 18:53, Byron Young wrote:<br>
><br>
>> Hi - I'm not sure what the repost policy on patches, but I have the<br>
>> feeling this one slipped through the cracks. Let me know if it's<br>
>> generally annoying to repost stuff.<br>
><br>
> No, reposting if things get dropped on the floor good :)<br>
><br>
> If you have time, then arriving on #catalyst-dev and making noise<br>
> also gets stuff done.<br>
><br>
>> This is a patch that allows you to suppress printing the value of<br>
>> certain query or body parameters when running Catalyst in debug<br>
>> mode - For example, if you want to hide passwords sent from the<br>
>> login page, you can put this in your app config (yaml):<br>
> Having been discussed in #catalyst-dev, we think that the patch could<br>
> be made both more generic, and more elegant.<br>
><br>
> The key thing is to split the table drawing, and the data filtering<br>
> into separate methods (maybe filter_debug_data?).<br>
><br>
> This would then allow you to filter per-type, and support things such as<br>
> redact_parameters (all), redact_body_parameters,<br>
> redact_query_parameters, and even potentially to add support for<br>
> filtering things like the URI (I can see use-cases where that'd be<br>
> significant - e.g. not wanting to log session IDs which are in URIs)..<br>
><br>
> Have a look at the way the debug screen stuff works (in<br>
> Catalyst::Engine), this is more elegant and would also benefit from<br>
> being able to have things redacted I guess - as with the current<br>
> patch, you're going to display the things you're redacting in the<br>
> logs to the end user...<br>
><br>
> Cheers<br>
> t0m<br>
><br>
<br>
</div></div>Tom,<br>
<br>
Thanks for the feedback. I think you're referring to $c->dump_these() and it's usage in finalize_error(). I'll refactor log_parameters() to call a separate method that will return the params to log, akin to dump_these(). Not sure when I'll have time for it since my current solution is working for me and I have some big deadlines coming up. Hopefully within the next month.<br>
<br>
Thanks<br>
<font color="#888888">byron<br>
</font><div><div></div><div><br>
<br>
_______________________________________________<br>
List: <a href="mailto:Catalyst@lists.scsys.co.uk" target="_blank">Catalyst@lists.scsys.co.uk</a><br>
Listinfo: <a href="http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst" target="_blank">http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst</a><br>
Searchable archive: <a href="http://www.mail-archive.com/catalyst@lists.scsys.co.uk/" target="_blank">http://www.mail-archive.com/catalyst@lists.scsys.co.uk/</a><br>
Dev site: <a href="http://dev.catalyst.perl.org/" target="_blank">http://dev.catalyst.perl.org/</a><br>
</div></div></blockquote></div><br></div></div>
</div></div></blockquote></div><br></div></div></div>
</blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
List: <a href="mailto:Catalyst@lists.scsys.co.uk">Catalyst@lists.scsys.co.uk</a><br>
Listinfo: <a href="http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst" target="_blank">http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst</a><br>
Searchable archive: <a href="http://www.mail-archive.com/catalyst@lists.scsys.co.uk/" target="_blank">http://www.mail-archive.com/catalyst@lists.scsys.co.uk/</a><br>
Dev site: <a href="http://dev.catalyst.perl.org/" target="_blank">http://dev.catalyst.perl.org/</a><br>
<br></blockquote></div><br>