[DBIx-Class-Devel] Branch cleanup

[Peter Rabbitson]

On Thu, Dec 13, 2012 at 05:18:02PM -0500, Brendan Byrd wrote:
> Deleted:
>    topic/rs_doc_fix2 - b12fcbdb181d2da5e676af1cc9deb0366a789e9e
>    pod/result_class - 14f8d7dbc7733f8da44c79b272da6f9cd8e51370
>    topic/docs-pod-inherit - 7a82dc29da2e8e0e5937d7b30c9ff93c9a01768a
>    topic/docfixes_pending - dff008c120eb810fcfb970d7390fe69625d11c4d
>    topic/more_docfixes_pending - d3d7a39c4549a196e7b249f57ef11e530b20519d

pod/result_class had some stuff you said you will look into incorporating
(2nd paragraph in [1]). I pushed the branch back as pod/resultclass_leftovers
If you changed your mind (i.e. it does not look as a good idea) - re-delete
it.

Btw the use of parent there is silly - parent when used in a project
alongside base actually makes things slower, not faster (yes, I did time it).
Furthermore once parent.pm shipped base.pm was optimised to work quickly in
most common cases. So the current state of parent.pm is like like that of
local $_ - cute but useless idea ;)

> Still need to be renamed:

>    topic/todo_test_cleanup --> abandoned/todo_test_cleanup

I will look into this again during the weekend (the amount of hackery you
pulled there is absolutely unwarranted)

>    force_explicit_join_type --> abandoned/force_explicit_join_type

I am moving this to historic_rejected/explicit_join_type, as per our 
previous conversation (it has tests in there that can be reused later). 
The concept of adding extra semantics *only* to custom relationship is 
architecturally unsound. For the proper way to do this - see [2] and the 
associated [3]

[1] http://lists.scsys.co.uk/pipermail/dbix-class-devel/2012-December/000150.html
[2] https://github.com/dbsrgits/dbix-class/blob/rfc/todo_list/lib/DBIx/Class/Manual/Dev/TODO.pod#relationship-arguments
[3] https://github.com/dbsrgits/dbix-class/blob/rfc/todo_list/lib/DBIx/Class/Manual/Dev/TODO.pod#Cleanup%2Frewrite_DBI%3A%3AClass%3A%3AResultSet%3A%3A_merge_joinpref_attr%28%29