[DBIx-Class-Devel] Review request topic/populate_doc (unrelated to Brendan's work)

Peter Rabbitson rabbit+dbic at rabbit.us
Fri Dec 14 14:35:41 GMT 2012


On Thu, Dec 13, 2012 at 01:51:59PM -0500, Brendan Byrd wrote:
> On Thu, Dec 13, 2012 at 8:48 AM, fREW Schmidt <frioux at gmail.com> wrote:
> > On Thu, Dec 13, 2012 at 06:21:16PM +1100, Peter Rabbitson wrote:
> >>
> >> Brendan, this is mostly a question to you: I am not entirely sure how
> >> to document the signature. Currently we have:
> >>
> >> =item Arguments: [ \@column_list, \@row_values+ ] | [ \%col_data+ ]
> >>
> >> I am not sure if the '+' is descriptive enough. Thoughts?
> >
> > Here's my idea.  It's wide, but clear:
> >
> >   =item Arguments: [ \@column_list, \@row_values+ ] | [ \%col_1_data, \%col_2_data, ... ]
> 
> or just \%col_data, \%col_data, ...
> 
> I've bantered around the idea myself in other things (like
> add_to_$rel).  If we use +, we should document that in ::Reading.

I wonder what castaway thinks? In either case - we need to pick one
and go with it. I have no preference myself - as long as there is
*something* to indicate the "one or many" nature of the signature.





More information about the DBIx-Class-Devel mailing list