[DBIx-Class-Devel] [dbix-class] Doc patch (#24)
Peter Rabbitson
rabbit+dbic at rabbit.us
Tue Apr 23 07:34:44 GMT 2013
On Tue, Apr 23, 2013 at 12:19:48AM +0100, Jess Robinson wrote:
>
> On Mon, 22 Apr 2013 10:52:10 +0100, Peter Rabbitson
> <rabbit+dbic at rabbit.us> wrote:
>
> >On Tue, Apr 16, 2013 at 07:50:57PM +0200, Alexander Hartmaier wrote:
> >>Why don't we get a mail to the list when a pull request has been
> >>closed, in
> >>this case by dbsrgits-sync?
> >
> >Because github... File a ticket?
>
> Hmm, this works well at $client's who are also using github.. I
> wonder why/how..
>
This case is a tad different - nobody clicked "close pull req". It was
auto-closed due to having the *exact* sha1 attached in the req appear in
the main repo. This happens when the patch needs no editing and is a
simple fast forward to apply to master (rare, but happens).
With *this* kind of close github seems to not send emails out. Pull reqs
aren't something I am that fond of (the github implementation of them,
not the idea in general), so not much motivation to dig for it on this
end ;)
Cheers
More information about the DBIx-Class-Devel
mailing list