[DBIx-Class-Devel] Re: [dbix-class] added timezone warnings (#28)

[Peter Rabbitson]

Hi,

First of all thanks for submitting a pull request, it clearly solves a problem you encountered. However, I am having a hard time justifying inclusion of a single "typo"-warning into the main codebase. If you feel strongly that this needs to go in (and the performance penalty is worth it) - please attempt to generalize the code, so other misspellings can be easily added (some sort of project-global hash or whatnot). Also within DBIC carp() is more or less banned - you ought to use either carp_uniqe provided by DBIx::Class::Carp.

I will keep this PR open for couple weeks, and close it without further action if I do not hear back from you.

Cheers

---
Reply to this email directly or view it on GitHub:
https://github.com/dbsrgits/dbix-class/pull/28#issuecomment-23240984
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.scsys.co.uk/pipermail/dbix-class-devel/attachments/20130825/31029516/attachment.htm