[DBIx-Class-Devel] dbh_do() subtly broken in 0.08205

[Peter Rabbitson]

On Fri, Feb 08, 2013 at 12:52:58PM +0100, Alexander Hartmaier wrote:
> On Fri, Feb 8, 2013 at 9:10 AM, Peter Rabbitson <rabbit+dbic at rabbit.us>wrote:
> 
> > On Thu, Feb 07, 2013 at 07:00:50PM +0100, Alexander Hartmaier wrote:
> > > On Thu, Feb 7, 2013 at 6:15 PM, Peter Rabbitson <rabbit+dbic at rabbit.us
> > >wrote:
> > >
> > > > On Fri, Feb 01, 2013 at 06:04:52PM +1100, Peter Rabbitson wrote:
> > > > > I had a brainfart when writing 6864429a [1], as a result 0.08205 has
> > a
> > > > > broken reconnector. Master [2] contains the necessary fix, please
> > test
> > > > > on your codebases and ship 0.08206 if no issues were found.
> > > > >
> > > > > Cheers
> > > > >
> > > > > [1] https://github.com/dbsrgits/dbix-class/commit/6864429a#L1L801
> > > > > [2] https://github.com/dbsrgits/dbix-class/commit/8f6986ac
> > > >
> > > > So um... no takers? I *really* do not want to ship this without a
> > > > 3rd party test (frew and/or abraxxa come to mind)
> > > >
> > > > Cheers
> > > >
> > > Thanks for the reminder, had a busy day but run its testsuite, installed
> > it
> > > and run my model and two app test suites.
> > > Those passed, but beware that they are not as complete as I'd like them
> > to
> > > be!
> > > A second real-world test by someone else is appreciated before I release
> > it.
> >
> > Hi Alex,
> >
> > Apparently nobody else on this list can be arsed (currently :), so
> > please ship it when time permits. I *think* your PAUSE perms are fine, if
> > they are not - let me know wat the indexer complain about and I will fix
> > them post-factum (and the same tarbal will reindex succesfully, no harm
> > done, no version lost).
> >
> > Cheers
> >
> Please test http://abraxxa.zorro.at/perl/DBIx-Class-0.08206.tar.gz
> 
> If I don't get a negative response till Monday I'll upload that exact file
> to CPAN, commit my locally modified Changes and lib/DBIx/Class.pm and tag
> the release.
> 

In the future it would help to explicitly mention that the above implies 
"Please no changes in master until Monday". While it does seem obvious, 
it is less likely folks will miss it.

Cheers and thanks for shepherding this throuh.