[DBIx-Class-Devel] Branch review request - topic/RT75394

[Peter Rabbitson]

On Sat, Feb 16, 2013 at 08:30:13PM +0100, Alexander Hartmaier wrote:
> On Sat, Feb 16, 2013 at 6:56 PM, Peter Rabbitson <rabbit+dbic at rabbit.us>wrote:
> 
> > https://github.com/dbsrgits/dbix-class/compare/topic;RT75394
> >
> > This properly fixes the long-standing RT#75394 (mainly affects anything
> > based on DBIx::Class::DeploymentHandler).
> >
> > Since the changeset includes POD and deprecations I want a second set of
> > eyes before merging it. Read the commit messages for more info.
> >
> > Please review and merge if no objections.
> >
> > Cheers
> >
> 
> Looks ok to me, second opinion wanted for merge.

Since nobody cares^Wspoke up I merged the branch with the following 
minimal changes:

rabbit at Ahasver:~/devel/dbic$ git diff b3f89187 31399b48
diff --git a/lib/SQL/Translator/Parser/DBIx/Class.pm b/lib/SQL/Translator/Parser/DBIx/Class.pm
index 3abce1d..527d5e5 100644
--- a/lib/SQL/Translator/Parser/DBIx/Class.pm
+++ b/lib/SQL/Translator/Parser/DBIx/Class.pm
@@ -486,17 +486,17 @@ conceptually identical output:
 
   my $yaml = SQL::Translator->new(
     parser => 'SQL::Translator::Parser::DBIx::Class',
-    producer => 'SQL::Translator::Producer::YAML',
-  )->translate($schema);
-
-  my $yaml = SQL::Translator->new(
-    parser => 'SQL::Translator::Parser::DBIx::Class',
     parser_args => {
       dbic_schema => $schema,
     },
     producer => 'SQL::Translator::Producer::YAML',
   )->translate;
 
+  my $yaml = SQL::Translator->new(
+    parser => 'SQL::Translator::Parser::DBIx::Class',
+    producer => 'SQL::Translator::Producer::YAML',
+  )->translate(data => $schema);
+
 =head2 add_fk_index
 
 Create an index for each foreign key.
diff --git a/t/99dbic_sqlt_parser.t b/t/99dbic_sqlt_parser.t
index cda26aa..82d9364 100644
--- a/t/99dbic_sqlt_parser.t
+++ b/t/99dbic_sqlt_parser.t
@@ -275,7 +275,7 @@ sub create_schema {
 
   $sqlt->parser('SQL::Translator::Parser::DBIx::Class');
   return $sqlt->translate(
-    $args->{schema} ? { data => $args->{schema} } : ()
+    $args->{schema} ? ( data => $args->{schema} ) : ()
   ) || die $sqlt->error;
 }