[DBIx-Class-Devel] [ANNOUNCE] A much faster DBIx::Class public trial round two - v0.08241

[Aaron Crane]

Peter Rabbitson <rabbit+dbic at rabbit.us> wrote:
> On Fri, Feb 22, 2013 at 05:06:27PM +0000, Aaron Crane wrote:
>> It's questionable code, easily fixed to work on either branch by
>> passing 'length(artist.name)' as a scalar reference, so I don't mind
>> at all if you reject the case for representing an incorrect user
>> expectation.
>
> Well... for one this would "work" if you s/columns =>/select =>/. But it
> will again stop working (also on 0.08206) the moment you enable
> quote_names => 1 in our connection attributes. So my instinct is to
> reject this as too much of a GIGO case.
>
> What do you think?

Sure, I'm fine with that — I've already fixed the code that the test
case was a reduction of, and I'm certainly not convinced that I was
thinking clearly when I wrote it. :-)

-- 
Aaron Crane ** http://aaroncrane.co.uk/