[DBIx-Class-Devel] [dbix-class] exception_action's ignorance of exceptions which stringify to empty string (#15)

lamoz notifications at github.com
Mon Jan 21 21:20:35 GMT 2013


I'm not sure about how to find out that exception happened the right way. It seems to me that there is no simple way to check that $@ contains exactly empty string but not something which pretends to be. I am used to check that exception happened by writing "if( $@ ) {...}" ie ckecking for true/false. So my fix proposition may be good for me but not for all cases out there.
You can merge this Pull Request by running:

  git pull https://github.com/lamoz/dbix-class master

Or you can view, comment on it, or merge it online at:

  https://github.com/dbsrgits/dbix-class/pull/15

-- Commit Summary --

  * Add tests and fix for exceptions which stringify to empty string handled by exception_action

-- File Changes --

    M lib/DBIx/Class/Storage/BlockRunner.pm (4)
    M t/33exception_wrap.t (13)
    M t/34exception_action.t (30)

-- Patch Links --

https://github.com/dbsrgits/dbix-class/pull/15.patch
https://github.com/dbsrgits/dbix-class/pull/15.diff

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.scsys.co.uk/pipermail/dbix-class-devel/attachments/20130121/08551e65/attachment.htm


More information about the DBIx-Class-Devel mailing list