[DBIx-Class-Devel] Re: [dbix-class] fixes a bug with the _dequalify_idents piece that stripped out schema. before a table name (#18)

[Peter Rabbitson]

Leaving aside the discussion whether DBIC should disallow "ugly" use cases or not - I think you are running the test on an old version of DBIC or something like this.
Bottom line is - no fix can go in without a test case, for 2 reasons.
1) There is no other definitive way to verify that the patch indeed does what it is supposed to do (i.e. `prove -l test.t` should pass `prove test.t` should fail)
2) There is no other definitive way to ensure a different edit of the code in question later on will not reintroduce the same breakage

I already did the tricky part for you in bd35f5fa3. Please modify this particular test https://github.com/dbsrgits/dbix-class/blob/master/t/resultset/update_delete.t#L326 (lifted from your comment above) so it actually *fails* without your patch. Then we can talk about the correct way of fixing this.

---
Reply to this email directly or view it on GitHub:
https://github.com/dbsrgits/dbix-class/pull/18#issuecomment-14612940
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.scsys.co.uk/pipermail/dbix-class-devel/attachments/20130308/5d0f1448/attachment.htm