[DBIx-Class-Devel] [dbix-class] Disconnect after schema version check. (#57)
Eric Miller
notifications at github.com
Sat Aug 30 02:35:11 GMT 2014
Thanks for the feedback. I have been developing and testing against the latest developer release. I agree that the first commit was a band-aid and believe that the new commits now address the underlying issue.
Rather than creating a new schema object with its own connection to the database, register_class is used to add DBIx::Class::Version::Table to the existing schema. A schema object and second connection is only used when initially creating the dbix_class_schema_versions table. All unit tests pass and have validated that a single connection is now used for both the version check and subsequent queries.
Once again, please let me know if you need additional information, would prefer a different approach, or would like other changes before acceptance.
---
Reply to this email directly or view it on GitHub:
https://github.com/dbsrgits/dbix-class/pull/57#issuecomment-53946506
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scsys.co.uk/pipermail/dbix-class-devel/attachments/20140829/d323920e/attachment.htm>
More information about the DBIx-Class-Devel
mailing list