[DBIx-Class-Devel] [sql-translator] improve add_trigger consistency between producers (#48)

andrewgregory notifications at github.com
Sun Dec 14 23:10:48 GMT 2014


Update Producer::SQLite and Producer::MySQL to only wrap the trigger
action in "BEGIN...END" when the user has not already done so, bringing
them in line with other producers and the add_trigger documentation.

Fixes #46.

Signed-off-by: Andrew Gregory <andrew.gregory.8 at gmail.com>
You can merge this Pull Request by running:

  git pull https://github.com/andrewgregory/sql-translator trigger

Or you can view, comment on it, or merge it online at:

  https://github.com/dbsrgits/sql-translator/pull/48

-- Commit Summary --

  * improve add_trigger consistency between producers

-- File Changes --

    M lib/SQL/Translator/Producer/MySQL.pm (7)
    M lib/SQL/Translator/Producer/SQLite.pm (4)
    M t/38-mysql-producer.t (45)
    M t/56-sqlite-producer.t (32)

-- Patch Links --

https://github.com/dbsrgits/sql-translator/pull/48.patch
https://github.com/dbsrgits/sql-translator/pull/48.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/dbsrgits/sql-translator/pull/48
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scsys.co.uk/pipermail/dbix-class-devel/attachments/20141214/614f13d3/attachment.htm>


More information about the DBIx-Class-Devel mailing list