[DBIx-Class-Devel] [dbix-class] removed FOREIGNBUILDARGS, it is unnecessary (#50)

Samuel Kaufman notifications at github.com
Thu Jul 3 22:01:03 GMT 2014


FOREIGNBUILDARGS is added by MooseX::NonMoose and is built into Moo.
It is designed for munging constructor parameters before sending them to the superclass, whereas BUILDARGS is for munging params in the subclass. It is unnecessary in this case, as Moo(se) ( the subclass ) is the one that needs it's constructor params munged, not DBIx::Class::ResultSet ( the superclass ).
You can merge this Pull Request by running:

  git pull https://github.com/ediblenergy/dbix-class wip/moo_resultsets_docs

Or you can view, comment on it, or merge it online at:

  https://github.com/dbsrgits/dbix-class/pull/50

-- Commit Summary --

  * removed FOREIGNBUILDARGS, it is unneccessary

-- File Changes --

    M lib/DBIx/Class/ResultSet.pm (2)

-- Patch Links --

https://github.com/dbsrgits/dbix-class/pull/50.patch
https://github.com/dbsrgits/dbix-class/pull/50.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/dbsrgits/dbix-class/pull/50
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scsys.co.uk/pipermail/dbix-class-devel/attachments/20140703/9959a783/attachment.htm>


More information about the DBIx-Class-Devel mailing list