[DBIx-Class-Devel] [sql-translator] fix Producer::SQLite::batch_alter_table rename field (#39)
Peter Mottram
notifications at github.com
Wed Jun 18 14:02:31 GMT 2014
rename_field is ignored by Producer::SQLite and the existing tests have:
SELECT ... physical_description FROM person"
which should be:
SELECT ... description FROM person"
Patches address this and try to make some of the code (mostly inside batch_alter_table) more readable.
You can merge this Pull Request by running:
git pull https://github.com/SysPete/sql-translator fixes/sqlite_rename_field
Or you can view, comment on it, or merge it online at:
https://github.com/dbsrgits/sql-translator/pull/39
-- Commit Summary --
* make Producer::SQLite::batch_alter_table more readable
* add sub _quote to Producer::SQLite
* start on fixing field rename in sqlite producer
* finish Producer::SQLite::batch_alter_table rename_field fix + update t
* go back to using new table for temp table ddl in Producer::SQLite
* remove some cruft from Producer::SQLite
-- File Changes --
M lib/SQL/Translator/Producer/SQLite.pm (125)
M t/30sqlt-new-diff-sqlite.t (4)
M t/72-sqlite-add-drop-fields.t (2)
-- Patch Links --
https://github.com/dbsrgits/sql-translator/pull/39.patch
https://github.com/dbsrgits/sql-translator/pull/39.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/dbsrgits/sql-translator/pull/39
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scsys.co.uk/pipermail/dbix-class-devel/attachments/20140618/ad34ce74/attachment.htm>
More information about the DBIx-Class-Devel
mailing list