[DBIx-Class-Devel] [sql-translator] Update JSON, YAML, & SQLite parsers to track table comments; fix YAML & JSON producers' table comments (#65)
djerius
notifications at github.com
Tue Aug 4 22:27:27 GMT 2015
The SQLite, YAML & JSON parsers (trivially) didn't track table comments. I've added that.
The YAML and JSON producers should have output comments as arrays; for table and field comments, they could croak or generate incorrect output if there was an even number of comments. For procedures, the comments were output as a concatenated string instead of an array.
You can view, comment on, or merge this pull request online at:
https://github.com/dbsrgits/sql-translator/pull/65
-- Commit Summary --
* add table comment parsing to sqlite parser
* JSON & YAML parsers now track table comments
* bugfix: JSON and YAML producers called comments method in wrong context
-- File Changes --
M lib/SQL/Translator/Parser/JSON.pm (4)
M lib/SQL/Translator/Parser/SQLite.pm (15)
M lib/SQL/Translator/Parser/YAML.pm (3)
M lib/SQL/Translator/Producer/JSON.pm (10)
M lib/SQL/Translator/Producer/YAML.pm (10)
M t/23json.t (1)
M t/24yaml.t (4)
M t/27sqlite-parser.t (8)
M t/data/sqlite/create.sql (3)
-- Patch Links --
https://github.com/dbsrgits/sql-translator/pull/65.patch
https://github.com/dbsrgits/sql-translator/pull/65.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/dbsrgits/sql-translator/pull/65
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scsys.co.uk/pipermail/dbix-class-devel/attachments/20150804/cb5ea8d1/attachment.htm>
More information about the DBIx-Class-Devel
mailing list